From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by mail.openembedded.org (Postfix) with ESMTP id 7AA1660304 for ; Tue, 18 Jun 2013 19:05:35 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.14.5/8.14.3) with ESMTP id r5IJ5boX017152 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL) for ; Tue, 18 Jun 2013 12:05:38 -0700 (PDT) Received: from Marks-MacBook-Pro.local (172.25.36.227) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.2.342.3; Tue, 18 Jun 2013 12:05:36 -0700 Message-ID: <51C0AF7F.3030309@windriver.com> Date: Tue, 18 Jun 2013 14:05:35 -0500 From: Mark Hatle Organization: Wind River Systems User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: References: <1371582707-26021-1-git-send-email-mark.hatle@windriver.com> In-Reply-To: <1371582707-26021-1-git-send-email-mark.hatle@windriver.com> Subject: Re: [PATCH] sanity.bbclass: Check for the known broken version of make X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jun 2013 19:05:35 -0000 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit On 6/18/13 2:11 PM, Mark Hatle wrote: > See GNU Savannah bug 30612 -- make 3.82 is known to be broken. > > A number of vendors are providing a modified version, so checking > for just the version string is not enough. We also need to check > if the patch for the issue has been applied. We use a modified > version of the reproduced to check for the issue. This was meant to go out as an RFC. The patch still hasn't been fully verified. Please don't merge it, but feedback would be appreciated! --Mark > Signed-off-by: Mark Hatle > --- > meta/classes/sanity.bbclass | 39 +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > > diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass > index 3b9934b..b7f3673 100644 > --- a/meta/classes/sanity.bbclass > +++ b/meta/classes/sanity.bbclass > @@ -336,6 +336,41 @@ def check_gcc_march(sanity_data): > > return result > > +# Unpatched version of make 3.82 are known to be broken. See GNU Savannah Bug 30612. > +# Use the reproducer from http://savannah.gnu.org/bugs/?30612 > +def check_make_version(sanity_data, loosever): > + status, result = oe.utils.getstatusoutput("make --version") > + if status != 0: > + return "Unable to execute make --version, exit code %s\n" % status > + version = result.split()[3] > + if not (loosever(version) < loosever("3.82") and loosever(version) > loosever("3.82")): > + # Construct a test file > + f = open("makefile_test", "w") > + f.write("makefile_test.a: makefile_test_a.c makefile_test_b.c makefile_test.a( makefile_test_a.c makefile_test_b.c)\n") > + f.write("\n") > + f.write("makefile_test_a.c:\n") > + f.write(" touch $@\n") > + f.write("\n") > + f.write("makefile_test_b.c:\n") > + f.write(" touch $@\n") > + f.close() > + > + # Check if make 3.82 has been patched > + status,result = oe.utils.getstatusoutput("make -f makefile_test") > + > + os.remove("makefile_test") > + if os.path.exists("makefile_test_a.c"): > + os.remove("makefile_test_a.c") > + if os.path.exists("makefile_test_b.c"): > + os.remove("makefile_test_b.c") > + if os.path.exists("makefile_test_a"): > + os.remove("makefile_test.a") > + > + if status != 0: > + return "Your version of make 3.82 is broken. Please revert to 3.81 or install a patched version.\n" > + return None > + > + > # Tar version 1.24 and onwards handle overwriting symlinks correctly > # but earlier versions do not; this needs to work properly for sstate > def check_tar_version(sanity_data, loosever): > @@ -407,6 +442,10 @@ def check_sanity(sanity_data): > messages = messages + 'Please set a MACHINE in your local.conf or environment\n' > machinevalid = False > > + makemsg = check_make_version(sanity_data, LooseVersion) > + if makemsg: > + messages = messages + makemsg > + > tarmsg = check_tar_version(sanity_data, LooseVersion) > if tarmsg: > messages = messages + tarmsg >