From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by mail.openembedded.org (Postfix) with ESMTP id 1AAED60130 for ; Wed, 19 Jun 2013 11:19:19 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.14.5/8.14.3) with ESMTP id r5JBJFmj019457 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 19 Jun 2013 04:19:15 -0700 (PDT) Received: from [128.224.162.205] (128.224.162.205) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.2.342.3; Wed, 19 Jun 2013 04:19:15 -0700 Message-ID: <51C19398.9080401@windriver.com> Date: Wed, 19 Jun 2013 19:18:48 +0800 From: Kang Kai User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Richard Purdie References: <1371629601.20823.161.camel@ted> In-Reply-To: <1371629601.20823.161.camel@ted> X-Originating-IP: [128.224.162.205] Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 2/2] strace: update to 4.8 X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jun 2013 11:19:19 -0000 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit On 2013年06月19日 16:13, Richard Purdie wrote: > On Wed, 2013-06-19 at 13:34 +0800, Kai Kang wrote: >> Update strace to 4.8. >> >> * Update License file. >> * Remove the backport patches which are already in version 4.8. >> * Add file git-version-gen from git repo. Without this file configure >> fails. >> * Add libaio and acl to PACKAGECONFIG for target package. Make libaio as a >> dependency by default which could be covered easily. >> >> Signed-off-by: Kai Kang > [...] > >> diff --git a/meta/recipes-devtools/strace/strace_4.8.bb b/meta/recipes-devtools/strace/strace_4.8.bb >> new file mode 100644 >> index 0000000..eb9f660 >> --- /dev/null >> +++ b/meta/recipes-devtools/strace/strace_4.8.bb >> @@ -0,0 +1,32 @@ >> +DESCRIPTION = "strace is a system call tracing tool." >> +HOMEPAGE = "http://strace.sourceforge.net" >> +SECTION = "console/utils" >> +LICENSE = "BSD" >> +LIC_FILES_CHKSUM = "file://COPYING;md5=124500c21e856f0912df29295ba104c7" >> +PR = "r0" >> + >> +SRC_URI = "${SOURCEFORGE_MIRROR}/strace/strace-${PV}.tar.xz \ >> + file://git-version-gen" >> + >> +SRC_URI[md5sum] = "c575ef43829586801f514fd91bfe7575" >> +SRC_URI[sha256sum] = "f492291f07a7c805c07a8395cce1ea054a6401ad414f4cc12185672215e1d7f8" >> +inherit autotools >> + >> +PACKAGECONFIG_class-target ?= "libaio" >> +PACKAGECONFIG_class-target += "${@base_contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}" >> + >> +PACKAGECONFIG[libaio] = ",,libaio," >> +PACKAGECONFIG[acl] = ",,acl," > Are there not --enable/--disable type options we can pass into configure > here to ensure build are deterministic? Configure just check headers, no such --enable/--disable options. > > Please also send this with move detection enabled in git so we get a > diff rather than a file removal/addition correctly shown (-M option to > git format-patch for example). It maybe changes too much that git doesn't take that as 'rename'. I will take 'git mv' as a seperate commit but that commit is not buildable, I will say that in comment. Regards, Kai > > Cheers, > > Richard > >> + >> +export INCLUDES = "-I. -I./linux" >> + >> +do_configure_prepend() { >> + cp ${WORKDIR}/git-version-gen ${S} >> +} >> + >> +do_install_append() { >> + # We don't ship strace-graph here because it needs perl >> + rm ${D}${bindir}/strace-graph >> +} >> + >> +BBCLASSEXTEND = "native" > > > -- Regards, Neil | Kai Kang