From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by mail.openembedded.org (Postfix) with ESMTP id 0E3D96AD79 for ; Tue, 25 Jun 2013 01:19:17 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.14.5/8.14.3) with ESMTP id r5P1JEG8021859 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Mon, 24 Jun 2013 18:19:15 -0700 (PDT) Received: from [128.224.162.211] (128.224.162.211) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.2.342.3; Mon, 24 Jun 2013 18:19:14 -0700 Message-ID: <51C8F010.1080603@windriver.com> Date: Tue, 25 Jun 2013 09:19:12 +0800 From: jhuang0 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Richard Purdie References: <51C7F903.9030809@windriver.com> <51C86361.6020703@linux.intel.com> <1372087414.9930.34.camel@ted> In-Reply-To: <1372087414.9930.34.camel@ted> Cc: openembedded-core Subject: Re: [PATCH 1/1] Limit the kbdrate application to x86, mips and sparc. X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jun 2013 01:19:17 -0000 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 6/24/2013 11:23 PM, Richard Purdie wrote: > On Mon, 2013-06-24 at 08:18 -0700, Saul Wold wrote: >> On 06/24/2013 12:45 AM, jhuang0 wrote: >>> >>> >>> On 6/24/2013 3:23 PM, Paul Barker wrote: >>>> On 24 Jun 2013 07:28, >>> > wrote: >>>> > >>>> > From: Jackie Huang >>> > >>>> > >>>> > The code relies on hardware specific memory locations to access >>>> > and modify the keyboard repeat rate. It also requires read/write >>>> > access to /dev/port which doesn't exist on every architecture's >>>> > root fs. The defect was raised for Qemu PowerPC but it also fails on >>>> > ARM. The keyboard emulation in qemuppc is for an ADB (Apple >>>> Desktop Bus) >>>> > device and not compatible with an Intel driver. There's also no >>>> > indication in the documentation that the code should work on >>>> > anything other than Intel architecture but it also works on MIPS. >>>> > >>>> >>>> > ++#if !( defined(__i386__) \ >>>> > ++ || defined(__x86_64__) \ >>>> > ++ || defined(__mips__) \ >>>> > ++ || defined(__sparc___)) >>>> > ++ >>>> > ++ fprintf(stderr, >>>> > ++ "ERROR: %s should only be used on MIPS, x86 and >>>> Sparc archicture boards\n", basename(argv[0])); >>>> > ++ exit(1); >>>> > ++#endif >>>> >>>> Would it be better to detect the target platform in the build system and >>>> skip building the kbdrate program for architectures it won't work on >>>> rather than building and installing a known broken program? >>> >>> Yeah, it should be better, I will check if we can do that. >>> >> Use COMPATIBLE_MACHINE > > We're after to take out a single binary, not the whole recipe? Yes, not the whole recipe, kbdrate is just one of the biaries provided by the kbd package, so I think it's not appropriate to use COMPATIBLE_MACHINE here. Thanks, Jackie > > Cheers, > > Richard > > -- Jackie Huang WIND RIVER | China Development Center MSN:jackielily@hotmail.com Tel: +86 8477 8594 Mobile: +86 138 1027 4745