From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by mail.openembedded.org (Postfix) with ESMTP id 19D616AEDE for ; Fri, 28 Jun 2013 13:16:58 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.14.5/8.14.3) with ESMTP id r5SDEs5a005129 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Fri, 28 Jun 2013 06:14:54 -0700 (PDT) Received: from Marks-MacBook-Pro.local (172.25.36.227) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.2.342.3; Fri, 28 Jun 2013 06:14:48 -0700 Message-ID: <51CD8C13.2070409@windriver.com> Date: Fri, 28 Jun 2013 08:13:55 -0500 From: Mark Hatle Organization: Wind River Systems User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: Paul Barker References: <1372342113-32763-1-git-send-email-mark.hatle@windriver.com> In-Reply-To: Cc: openembedded-core Subject: Re: [PATCH 1/3 v2] sanity.bbclass: Check for the known broken version of make X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jun 2013 13:16:58 -0000 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit On 6/28/13 5:20 AM, Paul Barker wrote: > On 27 June 2013 15:21, Burton, Ross wrote: >> On 27 June 2013 15:08, Mark Hatle wrote: >>> See GNU Savannah bug 30612 -- make 3.82 is known to be broken. >>> >>> A number of vendors are providing a modified version, so checking >>> for just the version string is not enough. We also need to check >>> if the patch for the issue has been applied. We use a modified >>> version of the reproduced to check for the issue. >>> >>> Signed-off-by: Mark Hatle >> >> Verified that this detects the 3.82 in Debian's experimental >> repository that is well and truly broken. >> >> Signed-off-by: Ross Burton >> > > This picks out the current version of make in Arch Linux as broken > despite it having a patch for bug #30612. I'm not sure if this is > intended, could be that the applied patch isn't a complete fix. I > don't have time to dig into this, just thought it'd be useful to you > to know. This is exactly why the check is being done. From what I found there are a number of make versions on various distros that only have partial fixes for bug 30612. For the RedHat/Fedora bug I filed, see: https://bugzilla.redhat.com/show_bug.cgi?id=975597 The test case, and a patch to the missing commit are listed. http://git.savannah.gnu.org/cgit/make.git/commit/?id=b06b8c64a29a5ba3a8daecd829fa2f98d42cb285 > If you know what fix you're looking for, the applied patches and build > script can be seen at > https://projects.archlinux.org/svntogit/packages.git/tree/trunk?h=packages/make Looking at that list, it appears the commit referenced above is indeed the one missing. --Mark > Thanks, > > -- > Paul Barker > > Email: paul@paulbarker.me.uk > http://www.paulbarker.me.uk >