From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by mail.openembedded.org (Postfix) with ESMTP id B8DA36AFD4 for ; Wed, 3 Jul 2013 20:11:53 +0000 (UTC) Received: from azsmga002.ch.intel.com ([10.2.17.35]) by azsmga101.ch.intel.com with ESMTP; 03 Jul 2013 13:11:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,990,1363158000"; d="scan'208";a="263782214" Received: from unknown (HELO [10.255.13.183]) ([10.255.13.183]) by AZSMGA002.ch.intel.com with ESMTP; 03 Jul 2013 13:11:44 -0700 Message-ID: <51D4857E.9060602@linux.intel.com> Date: Wed, 03 Jul 2013 13:11:42 -0700 From: Saul Wold User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: vmayoral References: <1372856665-29178-1-git-send-email-v.mayoralv@gmail.com> In-Reply-To: <1372856665-29178-1-git-send-email-v.mayoralv@gmail.com> Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH] apr_cv_mutex_recursive=yes added to apr_1.4.6.bb to make rosnodes work X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jul 2013 20:11:54 -0000 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 07/03/2013 06:04 AM, vmayoral wrote: > From: victor > > Working with the meta-ros project we detected that the ROS nodes didn't launch properly > the reason was that by default apr_cv_mutex_recursive in apr is set to no and this leads > to the APRENOTIMPL return value of apr_thread_mutex_create in thread_mutex.c when > APR_THREAD_MUTEX_NESTED is requested via flags. > > Added CACHED_CONFIGUREVARS += "apr_cv_mutex_recursive=yes" to sources/openembedded-core/meta/recipes-support/apr/apr_1.4.6.bb > to fix this issue. It has also been removed the mention of this variable in > meta/site/powerpc32-linux. > > Signed-off-by: Víctor Mayoral Vilches > --- > meta/recipes-support/apr/apr_1.4.6.bb | 3 +++ > meta/site/powerpc32-linux | 1 - > 2 files changed, 3 insertions(+), 1 deletion(-) > This really should be 2 patches, I know it was mentioned that you should make the change at the same time. But it should be done in seperate patches since they actually accomplishing different things. Also, the summary title of the commit should be in the format of: recipe or file: So in your case: apr: add apr_cv_mutex_recursive=yes to support meta-ros powerpc32-linux: remove apr_cv_mutex_recurisve ... Thanks Sau! > diff --git a/meta/recipes-support/apr/apr_1.4.6.bb b/meta/recipes-support/apr/apr_1.4.6.bb > index 896f79f..ba59639 100644 > --- a/meta/recipes-support/apr/apr_1.4.6.bb > +++ b/meta/recipes-support/apr/apr_1.4.6.bb > @@ -23,6 +23,9 @@ inherit autotools lib_package binconfig multilib_header > > OE_BINCONFIG_EXTRA_MANGLE = " -e 's:location=source:location=installed:'" > > +# Added to fix some issues with cmake. Refer to https://github.com/bmwcarit/meta-ros/issues/68#issuecomment-19896928 > +CACHED_CONFIGUREVARS += "apr_cv_mutex_recursive=yes" > + > do_configure_prepend() { > cd ${S} > ./buildconf > diff --git a/meta/site/powerpc32-linux b/meta/site/powerpc32-linux > index 4550df3..b3973c9 100644 > --- a/meta/site/powerpc32-linux > +++ b/meta/site/powerpc32-linux > @@ -203,7 +203,6 @@ apr_cv_use_lfs64=${apr_cv_use_lfs64=yes} > apr_cv_epoll=${apr_cv_epoll=yes} > apr_cv_pthreads_cflags=${apr_cv_pthreads_cflags=-pthread} > apr_cv_pthreads_lib=${apr_cv_pthreads_lib=-lpthread} > -apr_cv_mutex_recursive=${apr_cv_mutex_recursive=yes} > ac_cv_func_mmap=${ac_cv_func_mmap=yes} > ac_cv_file__dev_zero=${ac_cv_file__dev_zero=yes} > ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=4} >