From: Saul Wold <sgw@linux.intel.com>
To: Ming Liu <ming.liu@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] util-linux: replace += with _append to EXTRA_OECONF_virtclass-native
Date: Tue, 16 Jul 2013 23:51:05 -0700 [thread overview]
Message-ID: <51E63ED9.2000600@linux.intel.com> (raw)
In-Reply-To: <1374037784-7904-1-git-send-email-ming.liu@windriver.com>
On 07/16/2013 10:09 PM, Ming Liu wrote:
> The native/nativesdk overrides of EXTRA_OECONF should take effect before
> append operator, otherwise, it will cause EXTRA_OECONF be overridden instead
> of be appended at native/nativesdk build time.
>
I am not sure I understand this one. If what you are saying then all
the overrides in recipes need to be changed, that does not seem correct
to me.
Please confirm the overrides using += is correct.
Thanks
Sau!
> Signed-off-by: Ming Liu <ming.liu@windriver.com>
> ---
> meta/recipes-core/util-linux/util-linux_2.23.1.bb | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-core/util-linux/util-linux_2.23.1.bb b/meta/recipes-core/util-linux/util-linux_2.23.1.bb
> index 12f5021..e597c41 100644
> --- a/meta/recipes-core/util-linux/util-linux_2.23.1.bb
> +++ b/meta/recipes-core/util-linux/util-linux_2.23.1.bb
> @@ -18,5 +18,5 @@ SRC_URI[md5sum] = "6741eeaff93ff5a6bacdd3816bdd87c4"
> SRC_URI[sha256sum] = "ad4a7831d7b27d0172996fd343e809716c2403b32a94e15194d8ea797223c4af"
>
> CACHED_CONFIGUREVARS += "scanf_cv_alloc_modifier=as"
> -EXTRA_OECONF_class-native += "--disable-fallocate --disable-use-tty-group"
> -EXTRA_OECONF_class-nativesdk += "--disable-fallocate --disable-use-tty-group"
> +EXTRA_OECONF_append_virtclass-native = "--disable-fallocate --disable-use-tty-group"
> +EXTRA_OECONF_append_virtclass-nativesdk = "--disable-fallocate --disable-use-tty-group"
>
next prev parent reply other threads:[~2013-07-17 6:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 5:09 [PATCH] util-linux: replace += with _append to EXTRA_OECONF_virtclass-native Ming Liu
2013-07-17 6:51 ` Saul Wold [this message]
2013-07-17 8:13 ` Ming Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E63ED9.2000600@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=ming.liu@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox