Re: [PATCH V1] util-linux: replace += with _append to EXTRA_OECONF_virtclass-native

[Ming Liu <ming.liu@windriver.com>]

On 07/17/2013 04:31 PM, Paul Eggleton wrote:
> Hi Ming,
>
> On Wednesday 17 July 2013 16:19:39 Ming Liu wrote:
>> The native/nativesdk overrides of EXTRA_OECONF should take effect before
>> append operator, otherwise, it will cause EXTRA_OECONF be overridden instead
>> of be appended at native/nativesdk build time.
>>
>> Signed-off-by: Ming Liu <ming.liu@windriver.com>
>> ---
>>   meta/recipes-core/util-linux/util-linux_2.23.1.bb |    4 ++--
>>   1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-core/util-linux/util-linux_2.23.1.bb
>> b/meta/recipes-core/util-linux/util-linux_2.23.1.bb index 12f5021..ae80450
>> 100644
>> --- a/meta/recipes-core/util-linux/util-linux_2.23.1.bb
>> +++ b/meta/recipes-core/util-linux/util-linux_2.23.1.bb
>> @@ -18,5 +18,5 @@ SRC_URI[md5sum] = "6741eeaff93ff5a6bacdd3816bdd87c4"
>>   SRC_URI[sha256sum] =
>> "ad4a7831d7b27d0172996fd343e809716c2403b32a94e15194d8ea797223c4af"
>>
>>   CACHED_CONFIGUREVARS += "scanf_cv_alloc_modifier=as"
>> -EXTRA_OECONF_class-native += "--disable-fallocate --disable-use-tty-group"
>> -EXTRA_OECONF_class-nativesdk += "--disable-fallocate
>> --disable-use-tty-group" +EXTRA_OECONF_append_class-native +=
>> "--disable-fallocate --disable-use-tty-group"
>> +EXTRA_OECONF_append_class-nativesdk += "--disable-fallocate
>> --disable-use-tty-group"
> Could you please avoid the += in conjunction with _append? It's confusing.
> (You'll need to add a leading space to the value to compensate of course.)
Yes, sorry, my misktake. I will send V2.

the best,
thank you

> Thanks,
> Paul
>