From: Ming Liu <ming.liu@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH V2] util-linux: replace += with _append to EXTRA_OECONF_class-native
Date: Thu, 18 Jul 2013 09:30:14 +0800 [thread overview]
Message-ID: <51E74526.8010700@windriver.com> (raw)
In-Reply-To: <CAJTo0LZ+FnMvQ+b0orzchp2Aez4TB6_DYgCgr3wugc5ZDM4P7g@mail.gmail.com>
On 07/17/2013 08:07 PM, Burton, Ross wrote:
> On 17 July 2013 09:41, Ming Liu <ming.liu@windriver.com> wrote:
>> +EXTRA_OECONF_append_class-native = "--disable-fallocate --disable-use-tty-group"
>> +EXTRA_OECONF_append_class-nativesdk = "--disable-fallocate --disable-use-tty-group"
> _append won't add a leading space so you're making a massive
> assumption here, please add a leading space for safety.
Yes, thanks for the reminding, I will send the V3.
the best,
thank you
> Ross
>
>
prev parent reply other threads:[~2013-07-18 1:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 8:41 [PATCH V2] util-linux: replace += with _append to EXTRA_OECONF_class-native Ming Liu
2013-07-17 12:07 ` Burton, Ross
2013-07-18 1:30 ` Ming Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E74526.8010700@windriver.com \
--to=ming.liu@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox