Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Ionut Radu <ionutx.radu@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] fix traceback when inheriting useradd but not setting USERADD_PARAM or GROUPADD_PARAM (FuncFailed replaced by bb.fatal)
Date: Thu, 18 Jul 2013 15:47:20 -0700	[thread overview]
Message-ID: <51E87078.3090102@linux.intel.com> (raw)
In-Reply-To: <f0a9a68c227e86bd6239936a06d27129bf1e82f1.1374151585.git.ionutx.radu@intel.com>


Please fix the commit message to follow the guildlines:

http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

Thanks
	Sau!

On 07/18/2013 05:54 AM, Ionut Radu wrote:
> Signed-off-by: Ionut Radu <ionutx.radu@intel.com>
> ---
>   meta/classes/useradd.bbclass |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/useradd.bbclass b/meta/classes/useradd.bbclass
> index 3fe011d..a68b6fd 100644
> --- a/meta/classes/useradd.bbclass
> +++ b/meta/classes/useradd.bbclass
> @@ -219,7 +219,7 @@ def update_useradd_after_parse(d):
>
>       for pkg in useradd_packages.split():
>           if not d.getVar('USERADD_PARAM_%s' % pkg, True) and not d.getVar('GROUPADD_PARAM_%s' % pkg, True) and not d.getVar('GROUPMEMS_PARAM_%s' % pkg, True):
> -            raise bb.build.FuncFailed("%s inherits useradd but doesn't set USERADD_PARAM, GROUPADD_PARAM or GROUPMEMS_PARAM for package %s" % (d.getVar('FILE'), pkg))
> +            bb.fatal("%s inherits useradd but doesn't set USERADD_PARAM, GROUPADD_PARAM or GROUPMEMS_PARAM for package %s" % (d.getVar('FILE'), pkg))
>
>   python __anonymous() {
>       update_useradd_after_parse(d)
>


      reply	other threads:[~2013-07-18 22:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-18 12:54 [PATCH 0/1] fix: Traceback when inheriting useradd but not setting USERADD_PARAM or GROUPADD_PARAM (bug 4486) Ionut Radu
2013-07-18 12:54 ` [PATCH 1/1] fix traceback when inheriting useradd but not setting USERADD_PARAM or GROUPADD_PARAM (FuncFailed replaced by bb.fatal) Ionut Radu
2013-07-18 22:47   ` Saul Wold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E87078.3090102@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=ionutx.radu@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox