From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by mail.openembedded.org (Postfix) with ESMTP id 151E161013 for ; Thu, 8 Aug 2013 02:28:53 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.14.5/8.14.3) with ESMTP id r782SilI008373 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 7 Aug 2013 19:28:44 -0700 (PDT) Received: from [128.224.162.233] (128.224.162.233) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.2.342.3; Wed, 7 Aug 2013 19:28:44 -0700 Message-ID: <52030272.6050709@windriver.com> Date: Thu, 8 Aug 2013 10:29:06 +0800 From: ChenQi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: Khem Raj References: <3ea48b1c837fd67e81f367ff6943cae9f7fbeb33.1375862591.git.Qi.Chen@windriver.com> <5202FE14.70101@windriver.com> In-Reply-To: X-Originating-IP: [128.224.162.233] Cc: Chris Larson , "chen_q07@163.com" , Patches and discussions about the oe-core layer Subject: Re: [PATCH V4 09/10] irda-utils: fix for read-only rootfs X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Aug 2013 02:28:53 -0000 Content-Type: multipart/alternative; boundary="------------020606050204060303010301" --------------020606050204060303010301 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 08/08/2013 10:23 AM, Khem Raj wrote: > > > On Wednesday, August 7, 2013, ChenQi > wrote: > > On 08/07/2013 10:18 PM, Chris Larson wrote: > > > > On Wed, Aug 7, 2013 at 1:08 AM, > wrote: > >> > >> From: Chen Qi > > >> > >> The init script for irda writes configuration items to > /etc/sysconfig/irda > >> if that file is not available in system. But it's actually not > necessary, > >> the behavior doesn't change whether the init script writes to the > file or not. > >> > >> Considering it issues error messages in case of a read-only rootfs, > I delete > >> the writing process. > >> > >> [YOCTO #4103] > >> [YOCTO #4886] > >> > >> Signed-off-by: Chen Qi > > > > > This is a start, but is incomplete, from what I can tell. As > mentioned in the other thread, the startup script shouldn't be using > /etc/sysconfig/ at all, in any form. We use /etc/default/ for our > startup script config files, not /etc/sysconfig/. > > > > Yeah, I agree with you. > > But when I checked the irda source code, I saw that it actually > could ship its own init script (irda-utils-xxx/etc/irda.rc). And I > think our init script is derived from this one. In its own init > script, /etc/sysconfig is used. > > (Of course, I still think /etc/default is a better location for its > configuration file.) > > > > > > Also, the purpose of this block was clearly to implement a default > configuration, yet the recipe isn't altered to ship a default > configuration to provide equivalent functionality. > > > > In its source code, there's a default configuration file, and we > don't use that. I think there might be a reason. > > So I'm not sure about this one. > > > > If you have a patch to fix the irda issue properly, send it out and > I'll rebase my remote branch and drop this one. > > Whether Chris has a patch or not this patch in its form should be > dropped since there is a better way to do it > Shipping a default configuration file or using /etc/default as the configuration directory? Or something else? //Chen Qi > > > > Best Regards, > > Chen Qi > > > > > > -- > > Christopher Larson > > clarson at kergoth dot com > > Founder - BitBake, OpenEmbedded, OpenZaurus > > Maintainer - Tslib > > Senior Software Engineer, Mentor Graphics > > --------------020606050204060303010301 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 7bit
On 08/08/2013 10:23 AM, Khem Raj wrote:


On Wednesday, August 7, 2013, ChenQi <Qi.Chen@windriver.com> wrote:
> On 08/07/2013 10:18 PM, Chris Larson wrote:
>
> On Wed, Aug 7, 2013 at 1:08 AM, <Qi.Chen@windriver.com> wrote:
>>
>> From: Chen Qi <Qi.Chen@windriver.com>
>>
>> The init script for irda writes configuration items to /etc/sysconfig/irda
>> if that file is not available in system. But it's actually not necessary,
>> the behavior doesn't change whether the init script writes to the file or not.
>>
>> Considering it issues error messages in case of a read-only rootfs, I delete
>> the writing process.
>>
>> [YOCTO #4103]
>> [YOCTO #4886]
>>
>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>
> This is a start, but is incomplete, from what I can tell. As mentioned in the other thread, the startup script shouldn't be using /etc/sysconfig/ at all, in any form. We use /etc/default/ for our startup script config files, not /etc/sysconfig/.
>
> Yeah, I agree with you.
> But when I checked the irda source code, I saw that it actually could ship its own init script (irda-utils-xxx/etc/irda.rc). And I think our init script is derived from this one. In its own init script, /etc/sysconfig is used.
> (Of course, I still think /etc/default is a better location for its configuration file.)
>
>
> Also, the purpose of this block was clearly to implement a default configuration, yet the recipe isn't altered to ship a default configuration to provide equivalent functionality.
>
> In its source code, there's a default configuration file, and we don't use that. I think there might be a reason.
> So I'm not sure about this one.
>
> If you have a patch to fix the irda issue properly, send it out and I'll rebase my remote branch and drop this one.

Whether Chris has a patch or not this patch in its form should be dropped since there is a better way to do it


Shipping a default configuration file or using /etc/default as the configuration directory? Or something else?

//Chen Qi

>
> Best Regards,
> Chen Qi
>
>
> --
> Christopher Larson
> clarson at kergoth dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus
> Maintainer - Tslib
> Senior Software Engineer, Mentor Graphics
>

--------------020606050204060303010301--