Re: [PATCH 2/2 v2] meta-skeleton: Add busybox config fragment example

From: Saul Wold <sgw@linux.intel.com>
To: Mark Hatle <mark.hatle@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/2 v2] meta-skeleton: Add busybox config fragment example
Date: Tue, 13 Aug 2013 10:46:37 -0700	[thread overview]
Message-ID: <520A70FD.8000803@linux.intel.com> (raw)
In-Reply-To: <520A6C5C.3050308@windriver.com>

On 08/13/2013 10:26 AM, Mark Hatle wrote:
> On 8/13/13 12:11 PM, Saul Wold wrote:
>> This shows an example of the config fragment support that
>> both the linux-yocto and busybox recipes use. This example
>> is specific to busybox.
>>
>> By adding busybox CONFIG options into a .cfg file and then
>> adding that .cfg file to SRC_URI the merge_config.sh script will
>> correctly handle these CONFIG options during the do_configure task.
>>
>> v2: fixed FILESEXTRAPATHS
>>
>> Signed-off-by: Saul Wold <sgw@linux.intel.com>
>> ---
>>   meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg   | 1 +
>>   meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend | 5 +++++
>>   2 files changed, 6 insertions(+)
>>   create mode 100644
>> meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
>>   create mode 100644
>> meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
>>
>> diff --git a/meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
>> b/meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
>> new file mode 100644
>> index 0000000..42c6730
>> --- /dev/null
>> +++ b/meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
>> @@ -0,0 +1 @@
>> +CONFIG_RFKILL=n
>
> Should be "# CONFIG_RFKILL is not set", I believe the =n will work, but
> it doesn't following the kconfig conventions.
>
Yup, the commented out version works also, I will update the patch (v3), 
with


> --Mark
>
>> diff --git
>> a/meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
>> b/meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
>> new file mode 100644
>> index 0000000..641f04a4
>> --- /dev/null
>> +++ b/meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
>> @@ -0,0 +1,5 @@
>> +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>> +
>> +SRC_URI += " \
>> +        file://no_rfkill.cfg \
>> +           "
>>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>