From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay1.mentorg.com (relay1.mentorg.com [192.94.38.131]) by mail.openembedded.org (Postfix) with ESMTP id 0845F6010E for ; Mon, 19 Aug 2013 06:17:40 +0000 (UTC) Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1VBImY-0000nE-SZ from Muhammad_Shakeel@mentor.com ; Sun, 18 Aug 2013 23:17:38 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Sun, 18 Aug 2013 23:17:39 -0700 Received: from [137.202.157.119] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server (TLS) id 14.2.247.3; Mon, 19 Aug 2013 07:17:37 +0100 Message-ID: <5211B8C4.7070601@mentor.com> Date: Mon, 19 Aug 2013 11:18:44 +0500 From: Muhammad Shakeel User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 To: Khem Raj References: <1376674064-14468-1-git-send-email-muhammad_shakeel@mentor.com> In-Reply-To: X-Originating-IP: [137.202.0.76] X-OriginalArrivalTime: 19 Aug 2013 06:17:39.0078 (UTC) FILETIME=[CE0B6A60:01CE9CA3] Cc: Patches and discussions about the oe-core layer Subject: Re: [PATCH 1/4] [v3] openssh: Add systemd support X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Aug 2013 06:17:42 -0000 Content-Type: multipart/alternative; boundary="------------070908010406090705090301" --------------070908010406090705090301 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit On 08/16/2013 10:47 PM, Khem Raj wrote: > > > > On Fri, Aug 16, 2013 at 10:27 AM, Shakeel, Muhammad > > wrote: > > From: Muhammad Shakeel > > > -Remove dependency on meta-systemd > > +[Service] > +ExecStart=-/usr/sbin/sshd -i > > > > it would be nice if it was using libdir/bindir instead of hardcoded paths > coudld be achieved by generating the unit files from some sort of .in > files at build time so it could benefit > the distros which dont use /usr e.g. > > > + sed -i 's,/bin/,${base_bindir}/,g' > ${D}${systemd_unitdir}/system/sshd.socket > ${D}${systemd_unitdir}/system/sshd@.service > + sed -i 's,/usr/sbin/,${sbindir}/,g' > ${D}${systemd_unitdir}/system/sshd@.service > + sed -i 's,/usr/bin/,${bindir}/,g' > ${D}${systemd_unitdir}/system/sshdgenkeys.service > > /usr/sbin/ is being sed'ed with ${sbindir} in do_install_append of the respective recipe file. /usr/bin/ and /bin/ is also taken care of. Regards --------------070908010406090705090301 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 8bit

On 08/16/2013 10:47 PM, Khem Raj wrote:

On Fri, Aug 16, 2013 at 10:27 AM, Shakeel, Muhammad <muhammad_shakeel@mentor.com> wrote:

From: Muhammad Shakeel <muhammad_shakeel@mentor.com>

-Remove dependency on meta-systemd

+[Service]
+ExecStart=-/usr/sbin/sshd -i

it would be nice if it was using libdir/bindir instead of hardcoded paths

coudld be achieved by generating the unit files from some sort of .in files at build time so it could benefit

the distros which dont use /usr e.g.

+ sed -i 's,/bin/,${base_bindir}/,g' ${D}${systemd_unitdir}/system/sshd.socket ${D}${systemd_unitdir}/system/sshd@.service
+ sed -i 's,/usr/sbin/,${sbindir}/,g' ${D}${systemd_unitdir}/system/sshd@.service
+ sed -i 's,/usr/bin/,${bindir}/,g' ${D}${systemd_unitdir}/system/sshdgenkeys.service

/usr/sbin/ is being sed'ed with ${sbindir} in do_install_append of the respective recipe file. /usr/bin/ and /bin/ is also taken care of.

Regards
--------------070908010406090705090301--