Re: [PATCH 3/3] builder: register directories with pcmanfm

[Saul Wold <sgw@linux.intel.com>]

On 08/20/2013 09:41 AM, Iorga, Cristian wrote:
> Sould I remove PR entirely?
> Or just leave it at version 6?
> That's no mistake, I did change the PR because there are no external sources in this case, so there is not really a new version.
> Just an evolution.
>
Please try to do inline replies, as we prefer them to keep the context.

It should stay at PR="r6" to preserve the package version and 
upgradability. Removing PR would cause the package version to go backwards.

Sau!

> -----Original Message-----
> From: Saul Wold [mailto:sgw@linux.intel.com]
> Sent: Tuesday, August 20, 2013 7:38 PM
> To: Iorga, Cristian
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 3/3] builder: register directories with pcmanfm
>
> On 08/20/2013 09:05 AM, Cristian Iorga wrote:
>> Register directories to be opened with PCManFM filemanager using
>> xdg-open in Build Appliance.
>>
>> Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
>> ---
>>    meta/recipes-graphics/builder/builder_0.1.bb             | 2 +-
>>    meta/recipes-graphics/builder/files/builder_hob_start.sh | 9 +++++++++
>>    2 files changed, 10 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-graphics/builder/builder_0.1.bb
>> b/meta/recipes-graphics/builder/builder_0.1.bb
>> index 78d41e5..1e8c977 100644
>> --- a/meta/recipes-graphics/builder/builder_0.1.bb
>> +++ b/meta/recipes-graphics/builder/builder_0.1.bb
>> @@ -1,7 +1,7 @@
>>    SUMMARY = "New user to do specific job"
>>    DESCRIPTION = "This recipe create a new user named ${PN}, who is used for specific jobs like building. The task can be auto started via mini X"
>>    SECTION = "x11"
>> -PR = "r6"
>> +PR = "r7"
> No PR Bumps!
>
>>    LICENSE = "MIT"
>>    LIC_FILES_CHKSUM = "file://builder_hob_start.sh;endline=5;md5=84796c3c41785d86100fdabcbdade00e"
>>
>> diff --git a/meta/recipes-graphics/builder/files/builder_hob_start.sh
>> b/meta/recipes-graphics/builder/files/builder_hob_start.sh
>> index 40616f5..b3a0540 100644
>> --- a/meta/recipes-graphics/builder/files/builder_hob_start.sh
>> +++ b/meta/recipes-graphics/builder/files/builder_hob_start.sh
>> @@ -9,6 +9,15 @@ export PSEUDO_LOCALSTATEDIR=/home/builder/pseudo
>>    export PSEUDO_LIBDIR=/usr/lib/pseudo/lib64
>>    export GIT_PROXY_COMMAND=/home/builder/poky/scripts/oe-git-proxy
>>
>> +#start pcmanfm in daemon mode to allow asynchronous launch pcmanfm
>> +-d&
>> +
>> +#register folders to open with PCManFM filemanager if [ ! -d
>> +/home/ubik/tmp/.local/share/applications ]; then
>                     ^^^^^
> What's that user?  Should it be builder?
>
>> +    mkdir -p /home/builder/.local/share/applications/
>> +    xdg-mime default pcmanfm.desktop inode/directory fi
>> +
>>    cd /home/builder/poky
>>    . ./oe-init-build-env
>>
>>
>
>