Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: jackie.huang@windriver.com
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 6/6] openssh: add init.d/sshd status command for LSB compliance
Date: Wed, 21 Aug 2013 10:34:24 -0700	[thread overview]
Message-ID: <5214FA20.6090803@linux.intel.com> (raw)
In-Reply-To: <0b8b0b9d30aa7677a5c23e4d03d4ce6e21678ad7.1377064624.git.jackie.huang@windriver.com>

On 08/20/2013 11:15 PM, jackie.huang@windriver.com wrote:
> From: Jackie Huang <jackie.huang@windriver.com>
>
> Signed-off-by: Li Wang <li.wang@windriver.com>
> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> ---
>   .../openssh/openssh-6.2p2/init                     |   14 +++++++++++++-
>   1 files changed, 13 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-connectivity/openssh/openssh-6.2p2/init b/meta/recipes-connectivity/openssh/openssh-6.2p2/init
> index 12fb79b..72c5822 100644
> --- a/meta/recipes-connectivity/openssh/openssh-6.2p2/init
> +++ b/meta/recipes-connectivity/openssh/openssh-6.2p2/init
> @@ -1,6 +1,9 @@
>   #! /bin/sh
>   set -e
>
> +# source function library
> +. /etc/init.d/functions
> +
>   # /etc/init.d/ssh: start and stop the OpenBSD "secure shell" daemon
>
>   test -x /usr/sbin/sshd || exit 0
> @@ -54,6 +57,11 @@ check_keys() {
>   	fi
>   }
>
> +rh_status() {
> +	status /usr/sbin/sshd
> +	return $?
> +}
> +
>   export PATH="${PATH:+$PATH:}/usr/sbin:/sbin"
>
>   case "$1" in
> @@ -92,8 +100,12 @@ case "$1" in
>   	echo "."
>   	;;
>
> +  status)
> +	rh_status

Why rh_status here and in the "at" script?  Can't you just do the status 
/usr/bin/sshd directly here?

> +  ;;
> +
>     *)
> -	echo "Usage: /etc/init.d/ssh {start|stop|reload|force-reload|restart}"
> +	echo "Usage: /etc/init.d/ssh {start|stop|status|reload|force-reload|restart}"
>   	exit 1
>   esac
>
>


  reply	other threads:[~2013-08-21 17:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-21  6:15 [PATCH 0/6 v2] Add status command for daemon of some packages jackie.huang
2013-08-21  6:15 ` [PATCH 1/6] sysklogd: add init.d/syslog status command for LSB compliance jackie.huang
2013-08-21  6:15 ` [PATCH 2/6] at: add init.d/atd " jackie.huang
2013-08-21  6:15 ` [PATCH 3/6] dbus: add init.d/dbus-1 " jackie.huang
2013-08-21  6:15 ` [PATCH 4/6] sysvinit: add init.d/bootlogd " jackie.huang
2013-08-21  6:15 ` [PATCH 5/6] nfs-utils: add init.d/nfsserver " jackie.huang
2013-08-21 17:34   ` Saul Wold
2013-08-22  1:52     ` jhuang0
2013-08-21  6:15 ` [PATCH 6/6] openssh: add init.d/sshd " jackie.huang
2013-08-21 17:34   ` Saul Wold [this message]
2013-08-22  5:53     ` jhuang0
  -- strict thread matches above, loose matches on Subject: below --
2013-08-22  6:17 [PATCH 0/6 v3] Add status command for daemon of some packages jackie.huang
2013-08-22  6:17 ` [PATCH 6/6] openssh: add init.d/sshd status command for LSB compliance jackie.huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5214FA20.6090803@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=jackie.huang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox