From: Kang Kai <Kai.Kang@windriver.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-core@lists.openembedded.org, Zhangle.Yang@windriver.com
Subject: Re: [PATCH 1/1] bc: fix segmentation fault
Date: Thu, 22 Aug 2013 14:50:15 +0800 [thread overview]
Message-ID: <5215B4A7.8070604@windriver.com> (raw)
In-Reply-To: <760CDDA0-416D-4E16-8FC2-6205ED265506@gmail.com>
On 2013年08月22日 14:38, Khem Raj wrote:
> On Aug 19, 2013, at 7:20 PM, Kai Kang <kai.kang@windriver.com> wrote:
>
>> When run 'bc -l', it segmentation faults. Apply patch from BLFS to fix it.
>>
>> Ref:
>> http://www.mail-archive.com/blfs-support@linuxfromscratch.org/msg04601.html
>>
>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
>> ---
>> meta/recipes-extended/bc/bc_1.06.bb | 3 ++-
>> .../bc/files/fix-segment-fault.patch | 28 ++++++++++++++++++++++
>> 2 files changed, 30 insertions(+), 1 deletion(-)
>> create mode 100644 meta/recipes-extended/bc/files/fix-segment-fault.patch
>>
>> diff --git a/meta/recipes-extended/bc/bc_1.06.bb b/meta/recipes-extended/bc/bc_1.06.bb
>> index fe9c3f4..4b28fad 100644
>> --- a/meta/recipes-extended/bc/bc_1.06.bb
>> +++ b/meta/recipes-extended/bc/bc_1.06.bb
>> @@ -13,7 +13,8 @@ SECTION = "base"
>> DEPENDS = "flex"
>> PR = "r2"
>>
>> -SRC_URI = "${GNU_MIRROR}/bc/bc-${PV}.tar.gz"
>> +SRC_URI = "${GNU_MIRROR}/bc/bc-${PV}.tar.gz \
>> + file://fix-segment-fault.patch "
>>
>> SRC_URI[md5sum] = "d44b5dddebd8a7a7309aea6c36fda117"
>> SRC_URI[sha256sum] = "4ef6d9f17c3c0d92d8798e35666175ecd3d8efac4009d6457b5c99cea72c0e33"
>> diff --git a/meta/recipes-extended/bc/files/fix-segment-fault.patch b/meta/recipes-extended/bc/files/fix-segment-fault.patch
>> new file mode 100644
>> index 0000000..20c0da2
>> --- /dev/null
>> +++ b/meta/recipes-extended/bc/files/fix-segment-fault.patch
>> @@ -0,0 +1,28 @@
>> +Upstream-Status: Pending
>> +
>> +when run command such as 'echo "a = 13" | bc -l', it segmentation faults.
>> +This patch is from http://www.mail-archive.com/blfs-support@linuxfromscratch.org/msg04602.html.
>> +
>> +Signed-off-by: Kai Kang <kai.kang@windriver.com>
>> +
>> +--- bc-1.06/lib/number.c.orig 2003-09-26 21:14:02.000000000 +0000
>> ++++ bc-1.06/lib/number.c 2003-09-26 21:14:26.000000000 +0000
>> +@@ -34,6 +34,7 @@
>> + #include <number.h>
>> + #include <assert.h>
>> + #include <stdlib.h>
>> ++#include <string.h>
> what does adding this include file fix ?
To be honest, I am not sure why add this include. After build it is
harmless, so I didn't want to modify it because I think LFS is trustable.
Regards,
Kai
>
>> + #include <ctype.h>/* Prototypes needed for external utility routines. */
>> +
>> + #define bc_rt_warn rt_warn
>> +--- bc-1.06/bc/load.c.orig 2003-09-26 21:14:14.000000000 +0000
>> ++++ bc-1.06/bc/load.c 2003-09-26 21:14:26.000000000 +0000
>> +@@ -156,7 +156,7 @@
>> + long label_no;
>> + long vaf_name; /* variable, array or function number. */
>> + long func;
>> +- program_counter save_adr;
>> ++ static program_counter save_adr;
>> +
>> + /* Initialize. */
>> + str = code;
>> --
>> 1.8.1.2
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
--
Regards,
Neil | Kai Kang
next prev parent reply other threads:[~2013-08-22 6:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 2:20 [PATCH 0/1] Fix bc segmentation fault Kai Kang
2013-08-20 2:20 ` [PATCH 1/1] bc: fix " Kai Kang
2013-08-22 6:38 ` Khem Raj
2013-08-22 6:50 ` Kang Kai [this message]
2013-08-22 7:15 ` Khem Raj
2013-08-22 7:25 ` Kang Kai
2013-08-26 2:54 ` Kang Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5215B4A7.8070604@windriver.com \
--to=kai.kang@windriver.com \
--cc=Zhangle.Yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox