From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by mail.openembedded.org (Postfix) with ESMTP id 813E96B91D for ; Thu, 22 Aug 2013 07:02:41 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.14.5/8.14.3) with ESMTP id r7M72ePW012936 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Thu, 22 Aug 2013 00:02:40 -0700 (PDT) Received: from [128.224.162.247] (128.224.162.247) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.2.342.3; Thu, 22 Aug 2013 00:02:39 -0700 Message-ID: <5215B78D.9060900@windriver.com> Date: Thu, 22 Aug 2013 15:02:37 +0800 From: jhuang0 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Khem Raj References: <6f2bc301767250c371bb8d927e54425bdeda6f37.1376968627.git.jackie.huang@windriver.com> <54332AB2-FDDB-44C5-BCD8-00989CF8B700@gmail.com> In-Reply-To: <54332AB2-FDDB-44C5-BCD8-00989CF8B700@gmail.com> Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 4/6] openssh: add init.d/sshd status command for LSB compliance X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Aug 2013 07:02:42 -0000 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit On 8/22/2013 2:42 PM, Khem Raj wrote: > Hi Jackie > > One thing comes to mind is that these scripts are hardcoding the binaries and may be it would be > nicer to replace the bindir, libdir and so on at install time, that would make them flexible where /usr > is not used e.g. but I guess thats a general problem with capture init scripts all around probably. Yes it is general problem that almost all init scripts have these hardcoding binaries, maybe we need a requirement and do that for all these scripts with a plan. Thanks, Jackie > > On Aug 19, 2013, at 8:25 PM, jackie.huang@windriver.com wrote: > >> From: Jackie Huang >> >> Signed-off-by: Li Wang >> Signed-off-by: Jackie Huang >> --- >> .../openssh/openssh-6.2p2/init | 15 ++++++++++++++- >> 1 files changed, 14 insertions(+), 1 deletions(-) >> >> diff --git a/meta/recipes-connectivity/openssh/openssh-6.2p2/init b/meta/recipes-connectivity/openssh/openssh-6.2p2/init >> index 6beec84..6bbc573 100644 >> --- a/meta/recipes-connectivity/openssh/openssh-6.2p2/init >> +++ b/meta/recipes-connectivity/openssh/openssh-6.2p2/init >> @@ -1,6 +1,9 @@ >> #! /bin/sh >> set -e >> >> +# source function library >> +. /etc/init.d/functions >> + >> # /etc/init.d/ssh: start and stop the OpenBSD "secure shell" daemon >> >> test -x /usr/sbin/sshd || exit 0 >> @@ -46,6 +49,11 @@ check_keys() { >> fi >> } >> >> +rh_status() { >> + status /usr/sbin/sshd; >> + return $? >> +} >> + >> export PATH="${PATH:+$PATH:}/usr/sbin:/sbin" >> >> case "$1" in >> @@ -84,8 +92,13 @@ case "$1" in >> echo "." >> ;; >> >> + status) >> + rh_status; >> + exit $? >> + ;; >> + >> *) >> - echo "Usage: /etc/init.d/ssh {start|stop|reload|force-reload|restart}" >> + echo "Usage: /etc/init.d/ssh {start|stop|status|reload|force-reload|restart}" >> exit 1 >> esac >> >> -- >> 1.7.4.1 >> >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-core > > > -- Jackie Huang WIND RIVER | China Development Center MSN:jackielily@hotmail.com Tel: +86 8477 8594 Mobile: +86 138 1027 4745