From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by mail.openembedded.org (Postfix) with ESMTP id 6A8F36BC09 for ; Wed, 28 Aug 2013 00:34:28 +0000 (UTC) Received: from azsmga002.ch.intel.com ([10.2.17.35]) by azsmga102.ch.intel.com with ESMTP; 27 Aug 2013 17:34:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.89,971,1367996400"; d="scan'208";a="287605738" Received: from unknown (HELO [10.255.14.139]) ([10.255.14.139]) by AZSMGA002.ch.intel.com with ESMTP; 27 Aug 2013 17:34:26 -0700 Message-ID: <521D4590.40607@linux.intel.com> Date: Tue, 27 Aug 2013 17:34:24 -0700 From: Saul Wold User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 MIME-Version: 1.0 To: Rongqing Li References: <77319aeee8a2f49fa9ece78c4a0e4e20be3d4165.1377505592.git.rongqing.li@windriver.com> <521B6820.1000000@linux.intel.com> <521BFE8A.803@windriver.com> In-Reply-To: <521BFE8A.803@windriver.com> Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 1/1] btrfs-tools: Add dependency on lzo acl e2fsprog X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Aug 2013 00:34:29 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 08/26/2013 06:19 PM, Rongqing Li wrote: > > > On 08/26/2013 10:37 PM, Saul Wold wrote: >> >> Why? >> Still need give a better commit message about why these depends are needed. Sau! >> And should the acl be controlled by a PACKAGECONFIG? Can it be disabled >> during do_configure? >> >> Sau! > > btrfs-tools does not inherit autotools, and does not support the > configuration. > > it includes hard-code. > > The commit which includes is below: > > commit 62a72e7d9ada7a986dd299622b2233fe2e386003 > Author: Yan > Date: Mon Jan 14 13:35:00 2008 -0500 > > xattr support for the ext3->btrfs converter > > diff --git a/convert.c b/convert.c > index beb9a96..c047620 100644 > --- a/convert.c > +++ b/convert.c > @@ -25,6 +25,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -35,11 +36,10 @@ > #include "transaction.h" > #include "crc32c.h" > #include "utils.h" > -#include "ext2fs/ext2_fs.h" > -#include "ext2fs/ext2fs.h" > - > +#include > +#include > +#include > #define INO_OFFSET (BTRFS_FIRST_FREE_OBJECTID - EXT2_ROOT_INO) > - > /* > * Open Ext2fs in readonly mode, read block allocation bitmap and > * inode bitmap into memory. > @@ -446,7 +446,8 @@ static int __block_iterate_proc(ext2_filsys fs, > blk_t *blocknr, > static int create_file_extents(struct btrfs_trans_handle *trans, > struct btrfs_root *root, u64 objectid, > struct btrfs_inode_item *btrfs_inode, > - ext2_filsys ext2_fs, ext2_ino_t ext2_ino) > + ext2_filsys ext2_fs, ext2_ino_t ext2_ino, > + int datacsum, int packing) > > > > > > > > The btrfs-convert.c which include is below: > > > * but WITHOUT ANY WARRANTY; without even the implied warranty of > * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > * General Public License for more details. > * > * You should have received a copy of the GNU General Public > * License along with this program; if not, write to the > * Free Software Foundation, Inc., 59 Temple Place - Suite 330, > * Boston, MA 021110-1307, USA. > */ > > #define _XOPEN_SOURCE 600 > #define _GNU_SOURCE 1 > > #include "kerncompat.h" > > #ifndef __CHECKER__ > #include > #include > #endif > #include > #include > #include > #include > #include > > > both are hard-code. > > > -Roy > > >> >> On 08/26/2013 01:56 AM, rongqing.li@windriver.com wrote: >>> From: "Roy.Li" >>> >>> Signed-off-by: Roy.Li >>> --- >>> meta/recipes-devtools/btrfs-tools/btrfs-tools_git.bb | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/meta/recipes-devtools/btrfs-tools/btrfs-tools_git.bb >>> b/meta/recipes-devtools/btrfs-tools/btrfs-tools_git.bb >>> index 07e8529..3ec9e8a 100644 >>> --- a/meta/recipes-devtools/btrfs-tools/btrfs-tools_git.bb >>> +++ b/meta/recipes-devtools/btrfs-tools/btrfs-tools_git.bb >>> @@ -10,7 +10,7 @@ HOMEPAGE = "https://btrfs.wiki.kernel.org" >>> LICENSE = "GPLv2" >>> LIC_FILES_CHKSUM = >>> "file://COPYING;md5=fcb02dc552a041dee27e4b85c7396067" >>> SECTION = "base" >>> -DEPENDS = "util-linux attr" >>> +DEPENDS = "util-linux attr e2fsprogs lzo acl" >>> >>> SRCREV = "194aa4a1bd6447bb545286d0bcb0b0be8204d79f" >>> SRC_URI = >>> "git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-progs.git;protocol=git" >>> >>> >>> >> >> >