From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by mail.openembedded.org (Postfix) with ESMTP id EAF716BA7C for ; Wed, 28 Aug 2013 02:31:55 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.14.5/8.14.3) with ESMTP id r7S2Vuux005061 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Tue, 27 Aug 2013 19:31:57 -0700 (PDT) Received: from [128.224.162.233] (128.224.162.233) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.2.347.0; Tue, 27 Aug 2013 19:31:56 -0700 Message-ID: <521D612F.8080106@windriver.com> Date: Wed, 28 Aug 2013 10:32:15 +0800 From: ChenQi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-Version: 1.0 To: Phil Blundell References: <1377598478.5452.51.camel@phil-desktop.brightsign> In-Reply-To: <1377598478.5452.51.camel@phil-desktop.brightsign> X-Originating-IP: [128.224.162.233] Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 3/4] runqemu-internal: change the lock acquire/release logic X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Aug 2013 02:31:56 -0000 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 08/27/2013 06:14 PM, Phil Blundell wrote: > On Tue, 2013-08-27 at 15:08 +0800, Qi.Chen@windriver.com wrote: >> This patch simplifies the lock acquire/release logic by removing the >> flock mechanism. > I'm not sure that "simplifies" is an accurate description of the results > of removing flock. How about "breaks"? > > p. > > > > > That would be a better description. I then realized I did break the logic. I'll drop this patch and send out a v2. Best Regards, Chen Qi