From: Tomas Frydrych <tf+lists.yocto@r-finger.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] glib-2.0: fix a host contamination issue
Date: Tue, 03 Sep 2013 12:39:05 +0100 [thread overview]
Message-ID: <5225CA59.50307@r-finger.com> (raw)
In-Reply-To: <5225C515.9010804@windriver.com>
On 03/09/13 12:16, Robert Yang wrote:
>
>
> On 09/03/2013 05:51 PM, Burton, Ross wrote:
>> On 3 September 2013 08:52, Robert Yang <liezhi.yang@windriver.com> wrote:
>>> + sed -i -e 's/^\(ABS_GLIB_RUNTIME_LIBDIR=.*readlink\) -f/\1 -m/'
>>> ${S}/configure.ac
>>
>> Please do this as a patch instead of a sed.
>
> It seems that sed command is preferred ? For example, we don't have to
> port the
> patch once we upgrade glib-2.0.
Having to port a patch when it fails to apply ensures we are still doing
the right thing. In contrast, these sed snippets don't generate errors
when they fail, and they remain in recipes for years when no longer
working/needed.
Tomas
next prev parent reply other threads:[~2013-09-03 11:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 7:52 [PATCH 0/1] glib-2.0: fix a host contamination issue Robert Yang
2013-09-03 7:52 ` [PATCH 1/1] " Robert Yang
2013-09-03 9:51 ` Burton, Ross
2013-09-03 11:16 ` Robert Yang
2013-09-03 11:39 ` Tomas Frydrych [this message]
2013-09-03 11:48 ` Robert Yang
-- strict thread matches above, loose matches on Subject: below --
2013-09-03 12:37 [PATCH 0/1 V2] " Robert Yang
2013-09-03 12:37 ` [PATCH 1/1] " Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5225CA59.50307@r-finger.com \
--to=tf+lists.yocto@r-finger.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox