Openembedded Core Discussions
 help / color / mirror / Atom feed
From: ChenQi <Qi.Chen@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] udev-extraconf: Avoid mounting unknown filesystems
Date: Tue, 10 Sep 2013 16:55:57 +0800	[thread overview]
Message-ID: <522EDE9D.5080406@windriver.com> (raw)
In-Reply-To: <1366631550-12726-1-git-send-email-otavio@ossystems.com.br>

Hi Otavio,

This patch caused a new bug. So I'm afraid maybe this patch is not 
totally correct.
https://bugzilla.yoctoproject.org/show_bug.cgi?id=4487

The problem is that for a cdrom device, there's no ID_FS_TYPE.
Any idea?

Besides, could you please detail a little about what problem this patch 
is trying to solve?
Which kernel version is involved?

Best Regards,
Chen Qi


On 04/22/2013 07:52 PM, Otavio Salvador wrote:
> Depending on kernel version used, the system can hung when trying to
> mount the extended partition (not the logical one) as it is a holder
> for other partitions and does not have a filesystem in it.
>
> To avoid this to happen we just mount partitions when these are using
> known filesystems so it does not try to mount a partition for an
> unsupported filesystem.
>
> Reported-by: Vladan Jovanovic <vladan.jovanovic@gmail.com>
> Reported-by: Leonardo Sandoval Gonzalez <b42214@freescale.com>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> Tested-by: Vladan Jovanovic <vladan.jovanovic@gmail.com>
> ---
>   meta/recipes-core/udev/udev-extraconf/mount.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/udev/udev-extraconf/mount.sh b/meta/recipes-core/udev/udev-extraconf/mount.sh
> index 97af608..d1419ed 100644
> --- a/meta/recipes-core/udev/udev-extraconf/mount.sh
> +++ b/meta/recipes-core/udev/udev-extraconf/mount.sh
> @@ -47,7 +47,7 @@ rm_dir() {
>   	fi
>   }
>   
> -if [ "$ACTION" = "add" ] && [ -n "$DEVNAME" ]; then
> +if [ "$ACTION" = "add" ] && [ -n "$DEVNAME" ] && [ -n "$ID_FS_TYPE" ]; then
>   	if [ -x "$PMOUNT" ]; then
>   		$PMOUNT $DEVNAME 2> /dev/null
>   	elif [ -x $MOUNT ]; then



  reply	other threads:[~2013-09-10  8:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-22 11:52 [PATCH] udev-extraconf: Avoid mounting unknown filesystems Otavio Salvador
2013-09-10  8:55 ` ChenQi [this message]
2013-09-13 17:11   ` Otavio Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=522EDE9D.5080406@windriver.com \
    --to=qi.chen@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox