Re: [PATCH 2/5] cdrtools-native: Update from 3.00 to 3.01a17

[Saul Wold <sgw@linux.intel.com>]

On 09/12/2013 10:19 AM, Jason Wessel wrote:
> The update is needed to support generation of EFI boot images that
> work with optical media.  Specifically the "-eltorito-platform efi"
> capability for mkisofs is needed.
>
> [YOCTO #4100]
>
> Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
> ---
>   .../cdrtools/cdrtools-native_3.00.bb               |   30 -------------------
>   .../cdrtools/cdrtools-native_3.01a17.bb            |   31 ++++++++++++++++++++
>   2 files changed, 31 insertions(+), 30 deletions(-)
>   delete mode 100644 meta/recipes-devtools/cdrtools/cdrtools-native_3.00.bb
>   create mode 100644 meta/recipes-devtools/cdrtools/cdrtools-native_3.01a17.bb
>
> diff --git a/meta/recipes-devtools/cdrtools/cdrtools-native_3.00.bb b/meta/recipes-devtools/cdrtools/cdrtools-native_3.00.bb
> deleted file mode 100644
> index 7e4c381..0000000
> --- a/meta/recipes-devtools/cdrtools/cdrtools-native_3.00.bb
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -# cdrtools-native OE build file
> -# Copyright (C) 2004-2006, Advanced Micro Devices, Inc.  All Rights Reserved
> -# Released under the MIT license (see packages/COPYING)
> -SUMMARY = "A set of tools for CD recording, including cdrecord"
> -DESCRIPTION = "A set of tools for CD recording, including cdrecord"
> -HOMEPAGE = "http://cdrecord.berlios.de/private/cdrecord.html"
> -SECTION = "console/utils"
> -LICENSE = "GPLv2"
> -LIC_FILES_CHKSUM = "file://COPYING;md5=8d16123ffd39e649a5e4a6bc1de60e6d"
> -PR = "r0"
> -
> -SRC_URI = "ftp://ftp.berlios.de/pub/cdrecord/cdrtools-${PV}.tar.bz2 \
> -           file://no_usr_src.patch"
> -
> -SRC_URI[md5sum] = "f9fbab08fbd458b0d2312976d8c5f558"
> -SRC_URI[sha256sum] = "7f9cb64820055573b880f77b2f16662a512518336ba95ab49228a1617973423d"
> -
> -inherit native
> -
> -STAGE_TEMP = "${WORKDIR}/image-temp"
> -
> -FILESPATH = "${FILE_DIRNAME}/cdrtools-native/"
> -
> -do_install() {
> -	install -d ${STAGE_TEMP}
> -	make install INS_BASE=${STAGE_TEMP}
> -
> -	install -d ${D}${bindir}/
> -	install ${STAGE_TEMP}/bin/* ${D}${bindir}/
> -}
> diff --git a/meta/recipes-devtools/cdrtools/cdrtools-native_3.01a17.bb b/meta/recipes-devtools/cdrtools/cdrtools-native_3.01a17.bb
> new file mode 100644
> index 0000000..4a7a160
> --- /dev/null
> +++ b/meta/recipes-devtools/cdrtools/cdrtools-native_3.01a17.bb
> @@ -0,0 +1,31 @@
> +# cdrtools-native OE build file
> +# Copyright (C) 2004-2006, Advanced Micro Devices, Inc.  All Rights Reserved
> +# Released under the MIT license (see packages/COPYING)
> +SUMMARY = "A set of tools for CD recording, including cdrecord"
> +DESCRIPTION = "A set of tools for CD recording, including cdrecord"
> +HOMEPAGE = "http://cdrecord.berlios.de/private/cdrecord.html"
> +SECTION = "console/utils"
> +LICENSE = "GPLv2 & CDDL-1.0 & LGPLv2.1+"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=32f68170be424c2cd64804337726b312"
> +PR = "r0"
You can drop the PR completely.

> +
> +SRC_URI = "ftp://ftp.berlios.de/pub/cdrecord/alpha/cdrtools-${PV}.tar.bz2"
> +
> +SRC_URI[md5sum] = "4cef9db0cf15a770c52d65b00bbee2db"
> +SRC_URI[sha256sum] = "3d613965b213ad83e4be0ba2535e784901839ea4d11a20a2beb6765f0eb76dfa"
> +
> +S = "${WORKDIR}/cdrtools-3.01"
> +
> +inherit native
> +
> +STAGE_TEMP = "${WORKDIR}/image-temp"
> +
> +FILESPATH = "${FILE_DIRNAME}/cdrtools-native/"
> +
> +do_install() {
> +	install -d ${STAGE_TEMP}
> +	make install INS_BASE=${STAGE_TEMP}
> +
> +	install -d ${D}${bindir}/
> +	install ${STAGE_TEMP}/bin/* ${D}${bindir}/
> +}
>
I was working on this update also and was able to simplify this 
do_install to the following:

EXTRA_OEMAKE += "GMAKE_NOWARN=true INS_BASE=${prefix_native} DESTDIR=${D}

do_install() {
	oe_runmake install
}

This allowed me to get rid of the STAGE_TEMP

Sau!