Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Hongxu Jia <hongxu.jia@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] LSB 4.1 Library Check: fix unable to find library libqt-mt.so.3
Date: Fri, 13 Sep 2013 10:40:25 -0700	[thread overview]
Message-ID: <52334E09.4030905@linux.intel.com> (raw)
In-Reply-To: <a8596b9162366df23d07ad8206ddb0ce8863b699.1379073449.git.hongxu.jia@windriver.com>

On 09/13/2013 05:02 AM, Hongxu Jia wrote:
> The libqt-mt is tested by lsb-dist-checker and lsb-test-desktop,
> and it locates in meta-qt3 layer.
> So if meta-qt3 is not added, there should be a warning to call
> attention; if added, it will add libqt-mt to RDEPENDS.
>
> [YOCTO #5153]
>
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>   meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb b/meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb
> index 1c1a8d1..f83c5d7 100644
> --- a/meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb
> +++ b/meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb
> @@ -193,6 +193,15 @@ RDEPENDS_packagegroup-core-lsb-python = "\
>       python-misc \
>   "
>
> +def get_libqt3(d):
> +    if 'qt3' in d.getVar('BBFILE_COLLECTIONS') or "":
> +        return 'libqt-mt3'
> +
I think this should have a check for linuxstdbase so it does not print 
out at other times.

Sau!

> +    bb.warn('The meta-qt3 layer should be added, this layer provides Qt 3.x')
> +    bb.warn('libraries. Its intended use is for passing LSB tests as Qt3 is')
> +    bb.warn('a requirement for LSB')
> +    return ''
> +
>   SUMMARY_packagegroup-core-lsb-desktop = "LSB Desktop"
>   DESCRIPTION_packagegroup-core-lsb-desktop = "Packages required to support libraries \
>       specified in the LSB Desktop specification"
> @@ -221,6 +230,7 @@ RDEPENDS_packagegroup-core-lsb-desktop = "\
>       atk \
>       libasound \
>       ${@base_contains("DISTRO_FEATURES", "opengl", "libqtopengl4", "", d)} \
> +    ${@get_libqt3(d)} \
>   "
>
>   RDEPENDS_packagegroup-core-lsb-runtime-add = "\
>


  reply	other threads:[~2013-09-13 17:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-13 12:02 [PATCH 0/1]LSB 4.1 Library Check: fix unable to find library libqt-mt.so.3 Hongxu Jia
2013-09-13 12:02 ` [PATCH 1/1] LSB " Hongxu Jia
2013-09-13 17:40   ` Saul Wold [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-09-14  2:40 [PATCH V2 0/1] " Hongxu Jia
2013-09-14  2:40 ` [PATCH 1/1] " Hongxu Jia
2013-09-14  5:07   ` Saul Wold
2013-09-14  5:11     ` Hongxu Jia
2013-09-14  5:21     ` Hongxu Jia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52334E09.4030905@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=hongxu.jia@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox