From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mail.openembedded.org (Postfix) with ESMTP id 8DBFC61017 for ; Sat, 14 Sep 2013 05:07:54 +0000 (UTC) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 13 Sep 2013 22:07:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.90,902,1371106800"; d="scan'208";a="401560498" Received: from unknown (HELO [10.255.15.78]) ([10.255.15.78]) by fmsmga002.fm.intel.com with ESMTP; 13 Sep 2013 22:07:55 -0700 Message-ID: <5233EF2B.8050505@linux.intel.com> Date: Fri, 13 Sep 2013 22:07:55 -0700 From: Saul Wold User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 MIME-Version: 1.0 To: Hongxu Jia References: In-Reply-To: Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 1/1] LSB 4.1 Library Check: fix unable to find library libqt-mt.so.3 X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Sep 2013 05:07:55 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 09/13/2013 07:40 PM, Hongxu Jia wrote: > The libqt-mt is tested by lsb-dist-checker and lsb-test-desktop, > and it locates in meta-qt3 layer. > So if meta-qt3 is not added, there should be a warning to call > attention; if added, it will add libqt-mt to RDEPENDS. > > [YOCTO #5153] > > Signed-off-by: Hongxu Jia > --- > meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb b/meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb > index 1c1a8d1..c0dda5a 100644 > --- a/meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb > +++ b/meta/recipes-extended/packagegroups/packagegroup-core-lsb.bb > @@ -193,6 +193,16 @@ RDEPENDS_packagegroup-core-lsb-python = "\ > python-misc \ > " > > +def get_libqt3(d): > + if 'qt3' in d.getVar('BBFILE_COLLECTIONS') or "": > + return 'libqt-mt3' > + I think this might cause unexpected behavoir for people who just happen to have qt3 in their bblayer, I would also wrap the linuxstdbase around the above line. Sorry for not being clear about the first time. Sau! > + if 'linuxstdbase' in d.getVar('DISTROOVERRIDES') or "": > + bb.warn('The meta-qt3 layer should be added, this layer provides Qt 3.x') > + bb.warn('libraries. Its intended use is for passing LSB tests as Qt3 is') > + bb.warn('a requirement for LSB') > + return '' > + > SUMMARY_packagegroup-core-lsb-desktop = "LSB Desktop" > DESCRIPTION_packagegroup-core-lsb-desktop = "Packages required to support libraries \ > specified in the LSB Desktop specification" > @@ -221,6 +231,7 @@ RDEPENDS_packagegroup-core-lsb-desktop = "\ > atk \ > libasound \ > ${@base_contains("DISTRO_FEATURES", "opengl", "libqtopengl4", "", d)} \ > + ${@get_libqt3(d)} \ > " > > RDEPENDS_packagegroup-core-lsb-runtime-add = "\ >