From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f173.google.com (mail-lb0-f173.google.com [209.85.217.173]) by mail.openembedded.org (Postfix) with ESMTP id 4671360EDA for ; Sat, 14 Sep 2013 08:34:27 +0000 (UTC) Received: by mail-lb0-f173.google.com with SMTP id o14so2755559lbi.4 for ; Sat, 14 Sep 2013 01:34:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=KNGKekDgzUeS6/IL62k3x6XUouNo4o+LtIE3Kr16H68=; b=tgeeldSkn1ezuE/8RcFQAUif2LrZVTghJzKC2ZNIBaqr+eHFfY0tNaJTvM7Az/pHZA nZiKt2hH12PWynP3yp466LONuLeJhpjOQ5LJ5eCDiDDFF2XUr9JX6gyEdrHJt1iPc+7M MoTaixo6i7+/T1EvSAlT/eONbHOIdwkAhsi8rWx/3kztor5s5m+ujsyy2GLvatVo0euy DFUO1RKEkk5qCC3q/rGGqDBeNxRSowmx7cpTDt1WQo0Rvkjij5dN6kJKwQ3IgEVrBmv7 DHPBq/SzNV1VFAqk858tE9oKdLobXNel03f9jNDPx1tDvoEpJajViP0IVqdJQWKvHctU 0ZRQ== X-Received: by 10.112.190.1 with SMTP id gm1mr521674lbc.30.1379147668016; Sat, 14 Sep 2013 01:34:28 -0700 (PDT) Received: from [192.168.0.10] (h135n8-rny-a12.ias.bredband.telia.com. [217.209.54.135]) by mx.google.com with ESMTPSA id js17sm6215548lab.5.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 14 Sep 2013 01:34:27 -0700 (PDT) Message-ID: <52341F90.1060907@gmail.com> Date: Sat, 14 Sep 2013 10:34:24 +0200 From: Hans Beckerus User-Agent: Mozilla/5.0 (Windows NT 6.2; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: "openembedded-core@lists.openembedded.org" References: <5233941C.10406@gmail.com> In-Reply-To: <5233941C.10406@gmail.com> Subject: Re: [PATCH v5] libtool: fix resolve of lt_sysroot X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Sep 2013 08:34:27 -0000 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit I will commit a new patch. I just discovered a minor flaw in it. In an attempt to handle also the case that someone provides --with-libtool-sysroot ="/" the switch cases have wrong precedence since "/*" hits before "/". Sorry for overlooking this. Even if the chance of someone actually hitting this problem is slim, it think should be corrected. Thanks. Hans On 2013-09-14 12:39, Hans Beckerus wrote: > This patch updates libtool.m4 (and its output) to resolve a problem > with variable 'lt_sysroot' not being properly updated if the option > '--with[-libtool]-sysroot' is not provided when running the 'configure' > script for a package. > > According to the help text ouput from 'configure': > --with-libtool-sysroot=DIR Search for dependent libraries within DIR > (or the compiler's sysrooot if not specified). > > Due to mixed up cases in a switch statement, when checking if the option > was specified or not, wrong actions were taken resulting in an > incorrect sysroot and failures to properly locate e.g. .la files when > using the populated SDK toolchain. > > For current upstream status see: > http://lists.gnu.org/archive/html/bug-libtool/2013-09/msg00005.html > > Signed-off-by: Hans Beckerus > --- > meta/recipes-devtools/libtool/libtool-2.4.2.inc | 1 + > .../libtool/libtool/fix-resolve-lt-sysroot.patch | 40 ++++++++++++++++++++ > 2 files changed, 41 insertions(+) > create mode 100644 meta/recipes-devtools/libtool/libtool/fix-resolve-lt-sysroot.patch > > diff --git a/meta/recipes-devtools/libtool/libtool-2.4.2.inc b/meta/recipes-devtools/libtool/libtool-2.4.2.inc > index bb4ddf0..92e4949 100644 > --- a/meta/recipes-devtools/libtool/libtool-2.4.2.inc > +++ b/meta/recipes-devtools/libtool/libtool-2.4.2.inc > @@ -20,6 +20,7 @@ SRC_URI = "${GNU_MIRROR}/libtool/libtool-${PV}.tar.gz \ > file://respect-fstack-protector.patch \ > file://norm-rpath.patch \ > file://dont-depend-on-help2man.patch \ > + file://fix-resolve-lt-sysroot.patch \ > " > > SRC_URI[md5sum] = "d2f3b7d4627e69e13514a40e72a24d50" > diff --git a/meta/recipes-devtools/libtool/libtool/fix-resolve-lt-sysroot.patch b/meta/recipes-devtools/libtool/libtool/fix-resolve-lt-sysroot.patch > new file mode 100644 > index 0000000..9f9f22e > --- /dev/null > +++ b/meta/recipes-devtools/libtool/libtool/fix-resolve-lt-sysroot.patch > @@ -0,0 +1,40 @@ > + > +Upstream-Status: Pending > + > +This patch updates libtool.m4 (and its output) to resolve a problem > +with variable 'lt_sysroot' not being properly updated if the option > +'--with[-libtool]-sysroot' is not provided when running the 'configure' > +script for a package. > + > +I have also reported the problem to libtool here > + > +http://lists.gnu.org/archive/html/bug-libtool/2013-09/msg00005.html > + > +Signed-off-by: Hans Beckerus > +--- > +diff -ur libtool-2.4.2.orig/libltdl/m4/libtool.m4 libtool-2.4.2/libltdl/m4/libtool.m4 > +--- libtool-2.4.2.orig/libltdl/m4/libtool.m4 2013-09-13 22:37:43.647282945 +0200 > ++++ libtool-2.4.2/libltdl/m4/libtool.m4 2013-09-13 22:40:07.535285985 +0200 > +@@ -1234,15 +1234,20 @@ > + dnl in case the user passed a directory name. > + lt_sysroot= > + case ${with_libtool_sysroot} in #( > +- yes) > ++ no) > + if test "$GCC" = yes; then > + lt_sysroot=`$CC --print-sysroot 2>/dev/null` > ++ # Treat "/" the same a an unset sysroot. It seems to be more > ++ # compatible across host platforms that way!? > ++ if test "$lt_sysroot" = /; then > ++ lt_sysroot= > ++ fi > + fi > + ;; #( > + /*) > + lt_sysroot=`echo "$with_libtool_sysroot" | sed -e "$sed_quote_subst"` > + ;; #( > +- no|'') > ++ yes|''|/) > + ;; #( > + *) > + AC_MSG_RESULT([${with_libtool_sysroot}])