From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-la0-f42.google.com (mail-la0-f42.google.com [209.85.215.42]) by mail.openembedded.org (Postfix) with ESMTP id 02FF360EDA for ; Sat, 14 Sep 2013 09:01:40 +0000 (UTC) Received: by mail-la0-f42.google.com with SMTP id ep20so1784421lab.1 for ; Sat, 14 Sep 2013 02:01:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; bh=fFCNGY5nqGVVQEGPwLQPHO6FhTmOBTIsBK5e5iSf7ZE=; b=fBmW42UQgRZudiFgFpxU1tDDeaU91U7jiSsagBNaPUOCvyoyKCzAdezQFuWNEFuJEL uhgQwg4v5ID1ZE7yWBOBMY9hutdVvrD2qgSdIFuUmuHkw8UDDfEfxaYrZkY9w4luGBbY ZQEL9hzJA4q+/IGqFHu/+DZ8VdwcUbFA2DLG+0wHjBVljmnJYgtRhOOmQ+hhd4vRyJIM 2nkfb/SV2MPp1IshnaLUyKrDToCS1JUIUO340cWlPTLd/gKSxUDSDWAaZ+VmYd4a45Ec GG32SZpiDm6kKcUBajnL1K5JtZY/b+d6kSYpsZfewAqUmvE6YoRs1i+9+39Ra6cO36qY 9z0w== X-Received: by 10.112.168.35 with SMTP id zt3mr15365032lbb.11.1379149301363; Sat, 14 Sep 2013 02:01:41 -0700 (PDT) Received: from [192.168.0.10] (h135n8-rny-a12.ias.bredband.telia.com. [217.209.54.135]) by mx.google.com with ESMTPSA id pw4sm8018369lbb.9.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 14 Sep 2013 02:01:40 -0700 (PDT) Message-ID: <523425F2.9070109@gmail.com> Date: Sat, 14 Sep 2013 11:01:38 +0200 From: Hans Beckerus User-Agent: Mozilla/5.0 (Windows NT 6.2; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: "openembedded-core@lists.openembedded.org" Subject: [PATCH v6] libtool: fix resolve of lt_sysroot X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Sep 2013 09:01:41 -0000 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit This patch updates libtool.m4 (and its output) to resolve a problem with variable 'lt_sysroot' not being properly updated if the option '--with[-libtool]-sysroot' is not provided when running the 'configure' script for a package. According to the help text ouput from 'configure': --with-libtool-sysroot=DIR Search for dependent libraries within DIR (or the compiler's sysrooot if not specified). Due to mixed up cases in a switch statement, when checking if the option was specified or not, wrong actions were taken resulting in an incorrect sysroot and failures to properly locate e.g. .la files when using the populated SDK toolchain. For current upstream status see: http://lists.gnu.org/archive/html/bug-libtool/2013-09/msg00005.html Signed-off-by: Hans Beckerus --- Changes since v5: * Fixes a precedence issue in the switch case --- meta/recipes-devtools/libtool/libtool-2.4.2.inc | 1 + .../libtool/libtool/fix-resolve-lt-sysroot.patch | 41 ++++++++++++++++++++ 2 files changed, 42 insertions(+) create mode 100644 meta/recipes-devtools/libtool/libtool/fix-resolve-lt-sysroot.patch diff --git a/meta/recipes-devtools/libtool/libtool-2.4.2.inc b/meta/recipes-devtools/libtool/libtool-2.4.2.inc index bb4ddf0..92e4949 100644 --- a/meta/recipes-devtools/libtool/libtool-2.4.2.inc +++ b/meta/recipes-devtools/libtool/libtool-2.4.2.inc @@ -20,6 +20,7 @@ SRC_URI = "${GNU_MIRROR}/libtool/libtool-${PV}.tar.gz \ file://respect-fstack-protector.patch \ file://norm-rpath.patch \ file://dont-depend-on-help2man.patch \ + file://fix-resolve-lt-sysroot.patch \ " SRC_URI[md5sum] = "d2f3b7d4627e69e13514a40e72a24d50" diff --git a/meta/recipes-devtools/libtool/libtool/fix-resolve-lt-sysroot.patch b/meta/recipes-devtools/libtool/libtool/fix-resolve-lt-sysroot.patch new file mode 100644 index 0000000..44e9fe1 --- /dev/null +++ b/meta/recipes-devtools/libtool/libtool/fix-resolve-lt-sysroot.patch @@ -0,0 +1,41 @@ +Upstream-Status: Pending + +This patch updates libtool.m4 (and its output) to resolve a problem +with variable 'lt_sysroot' not being properly updated if the option +'--with[-libtool]-sysroot' is not provided when running the 'configure' +script for a package. + +I have also reported the problem to libtool here + +http://lists.gnu.org/archive/html/bug-libtool/2013-09/msg00005.html + +Signed-off-by: Hans Beckerus +--- +diff -ur libtool-2.4.2.orig/libltdl/m4/libtool.m4 libtool-2.4.2/libltdl/m4/libtool.m4 +--- libtool-2.4.2.orig/libltdl/m4/libtool.m4 2013-09-13 22:37:43.647282945 +0200 ++++ libtool-2.4.2/libltdl/m4/libtool.m4 2013-09-14 10:27:37.168178605 +0200 +@@ -1234,16 +1234,21 @@ + dnl in case the user passed a directory name. + lt_sysroot= + case ${with_libtool_sysroot} in #( +- yes) ++ no) + if test "$GCC" = yes; then + lt_sysroot=`$CC --print-sysroot 2>/dev/null` ++ # Treat "/" the same a an unset sysroot. It seems to be more ++ # compatible across host platforms that way!? ++ if test "$lt_sysroot" = /; then ++ lt_sysroot= ++ fi + fi + ;; #( ++ yes|''|/) ++ ;; #( + /*) + lt_sysroot=`echo "$with_libtool_sysroot" | sed -e "$sed_quote_subst"` + ;; #( +- no|'') +- ;; #( + *) + AC_MSG_RESULT([${with_libtool_sysroot}]) + AC_MSG_ERROR([The sysroot must be an absolute path.]) -- 1.7.9.5