Re: [PATCH] connman: Fix EXTRA_OECONF

[Jukka Rissanen <jukka.rissanen@linux.intel.com>]

On 13.09.2013 17:59, Muhammad Shakeel wrote:
> On 09/13/2013 05:56 PM, Jukka Rissanen wrote:
>> Hi Muhammad,
>>
>>> -PACKAGECONFIG[wifi] = "--enable-wifi, --disable-wifi, wpa-supplicant"
>>> -PACKAGECONFIG[bluetooth] = "--enable-bluetooth, --disable-bluetooth,
>>> bluez4"
>>> -PACKAGECONFIG[3g] = "--enable-ofono, --disable-ofono, ofono"
>>> +PACKAGECONFIG[wifi] = "--enable-wifi=builtin, --disable-wifi,
>>> wpa-supplicant"
>>> +PACKAGECONFIG[bluetooth] = "--enable-bluetooth=builtin,
>>> --disable-bluetooth --disable-dundee, bluez4"
>>> +PACKAGECONFIG[3g] = "--enable-ofono=builtin, --disable-ofono, ofono"
>>
>> There is no need to say builtin here as that is the default and those
>> plugins are always builtin anyways.
>>
> Hi Jukka,
> I did this change because I was trying to enable wifi, bluetooth and
> ofono through connman and I was getting this (for all these options):
> connmanctl> enable ofono
> Error ofono: Method "SetProperty" with signature "sv" on interface
> "net.connman.Technology" doesn't exist

You should have said "enable cellular". Ofono is name of the program, 
and "enable" command expect the name of the technology instead.

The connman commit 55f6589c3298b5cd36032aea98023474513c5b18 (found in 
ConnMan v1.18 or later) introduces technology name completion for the 
"enable" command. So you will see available technologies by pressing TAB 
after the "enable" command.

>
> I shared this on connman channel and what I got from there was:
> "connman plugins have not been installed. if you do --enable-bluetooth,
> bluetooth functionality is built as plugins and these plugins need to be
> installed. if you do --enable-bluetooth=builtin, the functionality is
> built into connman. if you specify nothing (as there is no reason to
> specify anything anyway), the functionality will be built into connman"
>
> and --enable-*=builtin worked for me. So either we should not mention
> anything or we have to use builtin otherwise (seems more intuitive). Do
> you think it should have worked without builtin and it was something
> else which was incorrect? has anyone else seen this error?

having --enable-bluetooth=builtin will have the same effect as 
--enable-bluetooth i.e., the builtin is optional and it is also the 
default value for bluetooth, wifi, ofono and dundee plugins (see ConnMan 
sources Makefile.plugins file and look for builtin modules).

So this part of the patch has no effect on functinality as those plugins 
are builtin already.


Cheers,
Jukka