Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] connman: Ignore the NFS root network interface in init script
Date: Mon, 16 Sep 2013 09:08:00 -0700	[thread overview]
Message-ID: <52372CE0.3060101@linux.intel.com> (raw)
In-Reply-To: <1378452180-2872-1-git-send-email-jukka.rissanen@linux.intel.com>

On 09/06/2013 12:23 AM, Jukka Rissanen wrote:
> The connman init.d script tried to ignore all the network interfaces
> if NFS root is configured. We should only ignore the interface
> that is used by NFS root.
>
> [YOCTO #4587]
>
> Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
> ---
>   meta/recipes-connectivity/connman/connman/connman | 14 ++++++++++++--
>   1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-connectivity/connman/connman/connman b/meta/recipes-connectivity/connman/connman/connman
> index 67ba7c8..2625ade 100644
> --- a/meta/recipes-connectivity/connman/connman/connman
> +++ b/meta/recipes-connectivity/connman/connman/connman
> @@ -29,8 +29,18 @@ done
>   do_start() {
>   	EXTRA_PARAM=""
>   	if test $nfsroot -eq 1 ; then
> -		ethn=`ifconfig | grep eth | sed -e "s/\(eth[0-9]\)\(.*\)/\1/"`
> -		EXTRA_PARAM="-I $ethn"
> +	    NET_DEVS=`cat /proc/net/dev | sed -ne 's/^\([a-zA-Z0-9 ]*\):.*$/\1/p'`
> +	    NET_ADDR=`cat /proc/cmdline | sed -ne 's/^.*ip=\([^ ]*\):.*$/\1/p'`
> +
> +	    if [ x$NET_ADDR != x ]; then
> +		for i in $NET_DEVS; do
> +		    ADDR=`ifconfig $i | sed 's/addr://g' | sed -ne 's/^.*inet \([0-9.]*\) .*$/\1/p'`
> +		    if [ "$NET_ADDR" = "$ADDR" ]; then
> +			EXTRA_PARAM="-I $i"
> +			break
> +		    fi
> +		done
> +	    fi
>   	fi
>   	if [ -f @LIBDIR@/connman/wired-setup ] ; then
>   		. @LIBDIR@/connman/wired-setup
>

This seems to have introduced a different issue, please see 
https://bugzilla.yoctoproject.org/show_bug.cgi?id=5176

Can you please look into this.

Thanks
	Sau!



  parent reply	other threads:[~2013-09-16 16:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-06  7:23 [PATCH] connman: Ignore the NFS root network interface in init script Jukka Rissanen
2013-09-09  6:11 ` Yi Zhao
2013-09-16 16:08 ` Saul Wold [this message]
2013-09-16 18:06 ` Enrico Scholz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52372CE0.3060101@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=jukka.rissanen@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox