From: Saul Wold <sgw@linux.intel.com>
To: Ross Burton <ross.burton@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] x11vnc: respect zeroconf DISTRO_FEATURE to enable Avahi support
Date: Thu, 19 Sep 2013 07:09:43 -0700 [thread overview]
Message-ID: <523B05A7.9090201@linux.intel.com> (raw)
In-Reply-To: <1379585199-27059-1-git-send-email-ross.burton@intel.com>
On 09/19/2013 03:06 AM, Ross Burton wrote:
> There's a standard way of announcing VNC services over mDNS that x11vnc
> supports, so respect the feature and enable/disable it.
>
> Also re-order the statements and drop the redundant PR.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
> meta/recipes-graphics/x11vnc/x11vnc_0.9.13.bb | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/meta/recipes-graphics/x11vnc/x11vnc_0.9.13.bb b/meta/recipes-graphics/x11vnc/x11vnc_0.9.13.bb
> index 0abc84a..098d8e8 100644
> --- a/meta/recipes-graphics/x11vnc/x11vnc_0.9.13.bb
> +++ b/meta/recipes-graphics/x11vnc/x11vnc_0.9.13.bb
> @@ -7,10 +7,6 @@ LICENSE = "GPLv2+"
> LIC_FILES_CHKSUM = "file://COPYING;md5=361b6b837cad26c6900a926b62aada5f \
> file://x11vnc/x11vnc.h;endline=33;md5=6f95dc6535467d7ee1563fd434fb372e"
>
> -DEPENDS = "openssl virtual/libx11 libxext avahi jpeg zlib libxfixes libxrandr libxdamage libxtst"
> -
> -PR = "r0"
> -
> SRC_URI = "${SOURCEFORGE_MIRROR}/libvncserver/x11vnc/${PV}/x11vnc-${PV}.tar.gz\
> file://starting-fix.patch \
> file://endian-fix.patch "
> @@ -18,5 +14,9 @@ SRC_URI = "${SOURCEFORGE_MIRROR}/libvncserver/x11vnc/${PV}/x11vnc-${PV}.tar.gz\
> SRC_URI[md5sum] = "a372ec4fe8211221547b1c108cf56e4c"
> SRC_URI[sha256sum] = "f6829f2e629667a5284de62b080b13126a0736499fe47cdb447aedb07a59f13b"
>
> +DEPENDS = "openssl virtual/libx11 libxext avahi jpeg zlib libxfixes libxrandr libxdamage libxtst"
> +
Did you intend to move the DEPENDS line here and keep avahi as you have
avahi in the PACKAGECONFIG below.
Sau!
> inherit autotools
>
> +PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'zeroconf', 'avahi', '', d)}"
> +PACKAGECONFIG[avahi] = "--with-avahi,--without-avahi,avahi"
>
next prev parent reply other threads:[~2013-09-19 14:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 10:06 [PATCH] x11vnc: respect zeroconf DISTRO_FEATURE to enable Avahi support Ross Burton
2013-09-19 14:09 ` Saul Wold [this message]
2013-09-19 14:16 ` Burton, Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523B05A7.9090201@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox