Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: "David Nyström" <david.c.nystrom@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCHv2] Add makedevs to nativesdk
Date: Mon, 23 Sep 2013 08:16:13 -0700	[thread overview]
Message-ID: <52405B3D.2060205@linux.intel.com> (raw)
In-Reply-To: <1379923288-1061-1-git-send-email-david.nystrom@enea.com>


You subject line in this patch and the libprelude patch still do not 
follow the guidelines, I pointed this out in the last review.

http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

It should be in the form of makedevs: add nativesdk to BBCLASSEXTEND

The patch itself is good, just the commit message needs to be formatted 
correctly.

Thanks
	Sau!


On 09/23/2013 01:01 AM, David Nyström wrote:
> This is a first in a series of patches to add items
> to the nativesdk toolchain tarball.
> Many of which are Yocto specific and needed to create a
> rootfs with pre and post install hooks successfully run,
> using only the toolchain tarball.
>
> End goal is to create a sandbox where _users_ of a Yocto
> based distribution can customize a rootfs from a package feed
> with their package manager of choice.
>
> Signed-off-by: David Nyström <david.nystrom@enea.com>
> ---
>   meta/recipes-devtools/makedevs/makedevs_1.0.0.bb | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/makedevs/makedevs_1.0.0.bb b/meta/recipes-devtools/makedevs/makedevs_1.0.0.bb
> index 2b9fd37..e6860f0 100644
> --- a/meta/recipes-devtools/makedevs/makedevs_1.0.0.bb
> +++ b/meta/recipes-devtools/makedevs/makedevs_1.0.0.bb
> @@ -19,4 +19,4 @@ do_install() {
>   	install -m 0755 ${S}/makedevs ${D}${base_sbindir}/makedevs
>   }
>
> -BBCLASSEXTEND = "native"
> +BBCLASSEXTEND = "native nativesdk"
>


      reply	other threads:[~2013-09-23 15:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-23  8:01 [PATCHv2] Add makedevs to nativesdk David Nyström
2013-09-23 15:16 ` Saul Wold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52405B3D.2060205@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=david.c.nystrom@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox