Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Ulf Samuelsson <ulf@emagii.com>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] Add tune for Cortex-A5 chips
Date: Mon, 21 Oct 2013 14:55:54 +0200	[thread overview]
Message-ID: <5265245A.2090201@emagii.com> (raw)
In-Reply-To: <20131021111757.GE3709@jama>

On 2013-10-21 13:17, Martin Jansa wrote:
> On Mon, Oct 21, 2013 at 10:59:57AM +0200, Ulf Samuelsson wrote:
>> Signed-off-by: Ulf Samuelsson <ulf@emagii.com>
>> ---
>>   meta/conf/machine/include/tune-cortexa5.inc |   24 ++++++++++++++++++++++++
>>   1 file changed, 24 insertions(+)
>>   create mode 100644 meta/conf/machine/include/tune-cortexa5.inc
>>
>> diff --git a/meta/conf/machine/include/tune-cortexa5.inc b/meta/conf/machine/include/tune-cortexa5.inc
>> new file mode 100644
>> index 0000000..69c945e
>> --- /dev/null
>> +++ b/meta/conf/machine/include/tune-cortexa5.inc
>> @@ -0,0 +1,24 @@
>> +DEFAULTTUNE ?= "cortexa5thf"
> wasn't cortexa5 added already in:
>
> commit 50bc63c5c377d9fbb87b3efefc8c6f5473ba642a
> Author: Andy Voltz <andy.voltz@timesys.com>
> Date:   Wed Jun 5 11:52:30 2013 -0400
>
>      tune-cortexa5.inc: Add tune file for cortex-a5
>
> I think that one was better, because it had optional neon support and
> default DEFAULTTUNE should be something more generic (at least to stay
> consistent with other tunes) it's DISTRO decision to select common
> denominator (or more specific tunes for each MACHINE) for binary feeds
> they want to manage.
Looks like you are right.
I looked at the openembedded-core in Angstrom master, and it wasn't there.
(
     because Angstrom master checks out
     "openembedded-core/remotes/origin/angstrom-staging-yocto1.3"
)

Sorry.

/Ulf

>
> see
> commit a11bdc36a1be18cc5aa14682b2a2c9ee83141f51
> Author: Martin Jansa <Martin.Jansa@gmail.com>
> Date:   Tue Oct 2 13:21:08 2012 +0000
>
>      tune-*: define more generic DEFAULTTUNE to share feed between
> machines
>
>> +# TUNE_FEATU4RES     = "armv7a vfp callconvention-hard"
>> +# TARGET_FPU        = "vfp"
>> +
>> +require conf/machine/include/arm/arch-armv7a.inc
>> +
>> +TUNEVALID[cortexa5] = "Enable Cortex-A5 specific processor optimizations"
>> +TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "cortexa5", "-mtune=cortex-a5", "", d)}"
>> +
>> +# Little Endian base configs
>> +AVAILTUNES += "cortexa5 cortexa5t"
>> +TUNE_FEATURES_tune-cortexa5 = "${TUNE_FEATURES_tune-armv7a} cortexa5"
>> +TUNE_FEATURES_tune-cortexa5t = "${TUNE_FEATURES_tune-armv7at} cortexa5"
>> +
>> +PACKAGE_EXTRA_ARCHS_tune-cortexa5 = "${PACKAGE_EXTRA_ARCHS_tune-armv7a}"
>> +PACKAGE_EXTRA_ARCHS_tune-cortexa5t = "${PACKAGE_EXTRA_ARCHS_tune-armv7at}"
>> +
>> +# VFP Tunes
>> +AVAILTUNES += "cortexa5hf cortexa5thf"
>> +TUNE_FEATURES_tune-cortexa5hf ?= "${TUNE_FEATURES_tune-armv7ahf} cortexa5"
>> +TUNE_FEATURES_tune-cortexa5thf ?= "${TUNE_FEATURES_tune-armv7athf} cortexa5"
>> +PACKAGE_EXTRA_ARCHS_tune-cortexa5hf = "${PACKAGE_EXTRA_ARCHS_tune-armv7ahf}"
>> +PACKAGE_EXTRA_ARCHS_tune-cortexa5thf = "${PACKAGE_EXTRA_ARCHS_tune-armv7athf}"
>> +
>> -- 
>> 1.7.9.5
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core


-- 
Best Regards
Ulf Samuelsson
ulf@emagii.com
+46 722 427437



  reply	other threads:[~2013-10-21 12:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-21  8:59 [PATCH] Add tune for Cortex-A5 chips Ulf Samuelsson
2013-10-21 11:17 ` Martin Jansa
2013-10-21 12:55   ` Ulf Samuelsson [this message]
2013-10-21 21:46     ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5265245A.2090201@emagii.com \
    --to=ulf@emagii.com \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox