Re: [oe][PATCHv2] libjson: update to 0.11 and rename to json-c

[Jack Mitchell <ml@communistcode.co.uk>]

On 28/10/2013 19:32, Khem Raj wrote:
> On Mon, Oct 21, 2013 at 1:56 AM, Jack Mitchell <ml@communistcode.co.uk> wrote:
>> From: Jack Mitchell <jmitchell@cbnl.com>
>>
>> libjson is now known as json-c, it keeps support for the old
>> libjson namespace so it shouldn't break anything. Built without
>> parallel make as it would fail when it tries to link to link back
>> to itself, which is odd, but the official word is: don't build in
>> parallel.
>>
>> Signed-off-by: Jack Mitchell <jmitchell@cbnl.com>
>> ---
>>
>>   v2: rebased to latest master
>>
>>   meta/conf/distro/include/seperatebuilddir.inc     |  2 +-
>>   meta/recipes-devtools/json-c/json-c_0.11.bb       | 13 +++++++++++++
>>   meta/recipes-devtools/libjson/libjson_0.9.bb      | 14 --------------
>>   meta/recipes-multimedia/pulseaudio/pulseaudio.inc |  2 +-
>>   4 files changed, 15 insertions(+), 16 deletions(-)
>>   create mode 100644 meta/recipes-devtools/json-c/json-c_0.11.bb
>>   delete mode 100644 meta/recipes-devtools/libjson/libjson_0.9.bb
>>
>> diff --git a/meta/conf/distro/include/seperatebuilddir.inc b/meta/conf/distro/include/seperatebuilddir.inc
>> index c067183..e1a5c6b 100644
>> --- a/meta/conf/distro/include/seperatebuilddir.inc
>> +++ b/meta/conf/distro/include/seperatebuilddir.inc
>> @@ -294,7 +294,7 @@ B_pn-libice = "${SEPB}"
>>   B_pn-libice-native = "${SEPB}"
>>   B_pn-libid3tag = "${SEPB}"
>>   B_pn-libidn = "${SEPB}"
>> -B_pn-libjson = "${SEPB}"
>> +B_pn-json-c = "${SEPB}"
>>   B_pn-libksba = "${SEPB}"
>>   B_pn-libmad = "${SEPB}"
>>   B_pn-libmatchbox = "${SEPB}"
>> diff --git a/meta/recipes-devtools/json-c/json-c_0.11.bb b/meta/recipes-devtools/json-c/json-c_0.11.bb
>> new file mode 100644
>> index 0000000..e0391f5
>> --- /dev/null
>> +++ b/meta/recipes-devtools/json-c/json-c_0.11.bb
>> @@ -0,0 +1,13 @@
>> +SUMMARY = "JSON-C implements a reference counting object model that allows you to easily construct JSON objects in C"
>> +HOMEPAGE = "https://github.com/json-c/json-c/wiki"
>> +LICENSE = "MIT"
>> +LIC_FILES_CHKSUM = "file://COPYING;md5=de54b60fbbc35123ba193fea8ee216f2"
>> +
>> +SRC_URI = "https://s3.amazonaws.com/json-c_releases/releases/${P}.tar.gz"
>
>
> be explicit and use BPN-PV so that if someday someone creates a
> mutation with native of nativesdk then it works there too.
> and keep RPROVIDE'ing libjson might make folks with feeds happier.
> and use git format-patch -M next time

Thanks for the feedback Khem. My local copy actually has the RPROVIDES 
already and that will come in V3. The patch was formatted with -M, I 
think git couldn't cope with the move and the changes, so just decided 
it was a full rewrite.

As for the BPN-PV, I don't really understand, I just grepped for 
libjson, and changed all the occurrences... the separate build dir being 
one of them, how would you expect the change to look?

Cheers,
Jack.

-- 

   Jack Mitchell (jack@embed.me.uk)
   Embedded Systems Engineer
   http://www.embed.me.uk

--