From: Qiang Chen <qiang.chen@windriver.com>
To: <richard.purdie@linuxfoundation.org>, Saul Wold <sgw@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] nfs-utils: modify nfsserver init script indent
Date: Tue, 29 Oct 2013 17:47:33 +0800 [thread overview]
Message-ID: <526F8435.1020604@windriver.com> (raw)
In-Reply-To: <1382418861-2658-1-git-send-email-qiang.chen@windriver.com>
Hi richard and Saul,
Any comment for this patch ?
If it's OK, could you please help merge to oe-core at your earliest convenience ?
Thanks a lot !
Qiang
On 10/22/2013 01:14 PM, qiang.chen@windriver.com wrote:
> From: Qiang Chen <qiang.chen@windriver.com>
>
> Using sysvinit testing service status, nfsserver status
> allways display as [?] unknown.
>
> This is because sysvinit package check whether service's
> init script supporting status function or not by:
> grep -qs "\Wstatus)" "$SERVICE"
>
> So, this commit modified the indent for status etc, as
> most service's init script does.
>
> Signed-off-by: Qiang Chen <qiang.chen@windriver.com>
> ---
> .../nfs-utils/nfs-utils/nfsserver | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils/nfsserver b/meta/recipes-connectivity/nfs-utils/nfs-utils/nfsserver
> index d7cf6e0..c263f14 100644
> --- a/meta/recipes-connectivity/nfs-utils/nfs-utils/nfsserver
> +++ b/meta/recipes-connectivity/nfs-utils/nfs-utils/nfsserver
> @@ -144,26 +144,26 @@ stop_statd(){
> # restart: stops and starts mountd
> #FIXME: need to create the /var/lib/nfs/... directories
> case "$1" in
> -start) create_directories
> + start) create_directories
> start_nfsd "$NFS_SERVERS"
> start_mountd
> start_statd
> test -r /etc/exports && exportfs -a;;
> -stop) exportfs -ua
> + stop) exportfs -ua
> stop_statd
> stop_mountd
> stop_nfsd;;
> -status)
> + status)
> status /usr/sbin/rpc.mountd
> RETVAL=$?
> status nfsd
> rval=$?
> [ $RETVAL -eq 0 ] && exit $rval
> exit $RETVAL;;
> -reload) test -r /etc/exports && exportfs -r;;
> -restart)
> + reload) test -r /etc/exports && exportfs -r;;
> + restart)
> $0 stop
> $0 start;;
> -*) echo "Usage: $0 {start|stop|status|reload|restart}"
> + *) echo "Usage: $0 {start|stop|status|reload|restart}"
> exit 1;;
> esac
>
prev parent reply other threads:[~2013-10-29 9:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 5:14 [PATCH] nfs-utils: modify nfsserver init script indent qiang.chen
2013-10-29 9:47 ` Qiang Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526F8435.1020604@windriver.com \
--to=qiang.chen@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
--cc=sgw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox