Re: [v2][PATCH 1/1] vala.bbclass: add dependency on vala

[Saul Wold <sgw@linux.intel.com>]

On 09/26/2013 11:52 AM, Joe Slater wrote:
> This class points the inheritor, if it is a target,
> to directories in the target sysroot, so we want to
> be sure the .vapi files are there.
>
> Signed-off-by: Joe Slater <jslater@windriver.com>
> ---
>   meta/classes/vala.bbclass |    8 +++++---
>   1 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/meta/classes/vala.bbclass b/meta/classes/vala.bbclass
> index c7db08c..3b70a04 100644
> --- a/meta/classes/vala.bbclass
> +++ b/meta/classes/vala.bbclass
> @@ -1,9 +1,11 @@
>   # Vala has problems with multiple concurrent invocations
>   PARALLEL_MAKE = ""
>
> -# Vala needs vala-native
> -DEPENDS += "vala-native"
> -DEPENDS_virtclass-native += "vala-native"
> +# Everyone needs vala-native and targets need vala, too,
> +# because that is where target builds look for .vapi files.
> +#
> +VALADEPENDS_class-target = "vala"
> +DEPENDS_append = " vala-native ${VALADEPENDS}"
You should really have a default value for VALADEPENDS = "", the above 
class override relies on bitbake behaviour which could change.

Thanks

Sau!

>
>   # Our patched version of Vala looks in STAGING_DATADIR for .vapi files
>   export STAGING_DATADIR
>