From: Yang Shi <yang.shi@windriver.com>
To: <b28495@freescale.com>, <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/2] perf: flag __SANE_USERSPACE_TYPES__ to include int-ll64.h for powerpc64
Date: Tue, 29 Oct 2013 20:45:22 -0700 [thread overview]
Message-ID: <527080D2.2020301@windriver.com> (raw)
In-Reply-To: <1381479105-21972-1-git-send-email-b28495@freescale.com>
On 10/11/2013 1:11 AM, b28495@freescale.com wrote:
> From: Ting Liu <b28495@freescale.com>
>
> PPC64 uses long long for u64 in the kernel, but powerpc's asm/types.h
> prevents 64-bit userland from seeing this definition, instead defaulting
> to u64 == long in userspace.
> Perf want LL64, flag __SANE_USERSPACE_TYPES__ to get int-ll64.h.
>
> Fix the below issue:
> | tests/attr.c:71:4: error: format '%llu' expects argument of type 'long
> long unsigned int', but argument 6 has type '__u64' [-Werror=format=]
> | tests/attr.c:80:7: error: format '%llu' expects argument of type 'long
> long unsigned int', but argument 4 has type '__u64' [-Werror=format=]
> | attr->type, attr->config, fd) < 0) {
> | ^
>
> Signed-off-by: Ting Liu <b28495@freescale.com>
> ---
> meta/recipes-kernel/perf/perf.bb | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
> index 269069f..d27e535 100644
> --- a/meta/recipes-kernel/perf/perf.bb
> +++ b/meta/recipes-kernel/perf/perf.bb
> @@ -89,6 +89,12 @@ EXTRA_OEMAKE += "\
> 'infodir=${@oe.path.relative(prefix, infodir)}' \
> "
>
> +# PPC64 uses long long for u64 in the kernel, but powerpc's asm/types.h
> +# prevents 64-bit userland from seeing this definition, instead defaulting
> +# to u64 == long in userspace. Define __SANE_USERSPACE_TYPES__ to get
> +# int-ll64.h included.
> +EXTRA_OEMAKE_append_powerpc64 = ' CFLAGS=-D__SANE_USERSPACE_TYPES__'
This override perf CFLAGS incorrectly.
kernel commit e3541ec75219819d3235f80125a1a75d798ff6e1 can solve this
build issue.
Yang
> +
> PARALLEL_MAKE = ""
>
> do_compile() {
prev parent reply other threads:[~2013-10-30 3:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 8:11 [PATCH 1/2] perf: flag __SANE_USERSPACE_TYPES__ to include int-ll64.h for powerpc64 b28495
2013-10-11 8:11 ` [PATCH 2/2] socat: add dependency on tcp-wrappers b28495
2013-10-30 3:45 ` Yang Shi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527080D2.2020301@windriver.com \
--to=yang.shi@windriver.com \
--cc=b28495@freescale.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox