From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.chez-thomas.org (mail.mlbassoc.com [65.100.170.105]) by mail.openembedded.org (Postfix) with ESMTP id 73FAC6B0F9 for ; Wed, 30 Oct 2013 15:39:53 +0000 (UTC) Received: by mail.chez-thomas.org (Postfix, from userid 1998) id 81DADF81213; Wed, 30 Oct 2013 09:39:55 -0600 (MDT) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on hermes.chez-thomas.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=4.0 tests=ALL_TRUSTED,BAYES_00 autolearn=unavailable version=3.3.2 Received: from [192.168.1.114] (zeus [192.168.1.114]) by mail.chez-thomas.org (Postfix) with ESMTP id 8EF80F81211; Wed, 30 Oct 2013 09:39:54 -0600 (MDT) Message-ID: <52712859.6070002@mlbassoc.com> Date: Wed, 30 Oct 2013 09:40:09 -0600 From: Gary Thomas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Paul Eggleton References: <5271162B.6020008@mlbassoc.com> <2034563.H7dbApMjKG@helios> <52711DCD.7080401@mlbassoc.com> <1953485.uklNZh2O8P@helios> In-Reply-To: <1953485.uklNZh2O8P@helios> Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH] core-image-basic.bb: Allow user extensions X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Oct 2013 15:39:53 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 2013-10-30 09:33, Paul Eggleton wrote: > On Wednesday 30 October 2013 08:55:09 Gary Thomas wrote: >> On 2013-10-30 08:47, Paul Eggleton wrote: >>> On Wednesday 30 October 2013 08:22:35 Gary Thomas wrote: >>>> Allow the user to provide additional packages to this image. >>>> This lets core-image-basic behave like all other core-image* >>>> recipes (which do support CORE_IMAGE_EXTRA_INSTALL), as well >>>> as match the documentation which suggests this as the mode to >>>> extend any core-image* image. >>>> >>>> Signed-off-by: Gary Thomas >>>> --- >>>> >>>> meta/recipes-extended/images/core-image-basic.bb | 3 +++ >>>> 1 file changed, 3 insertions(+) >>>> >>>> diff --git a/meta/recipes-extended/images/core-image-basic.bb >>>> b/meta/recipes-extended/images/core-image-basic.bb index 091f57d..e393a28 >>>> 100644 >>>> --- a/meta/recipes-extended/images/core-image-basic.bb >>>> +++ b/meta/recipes-extended/images/core-image-basic.bb >>>> @@ -3,9 +3,12 @@ functionality installed." >>>> >>>> IMAGE_FEATURES += "splash ssh-server-openssh" >>>> >>>> +CORE_IMAGE_EXTRA_INSTALL ?= "" >>>> >>>> + >>> >>> Not sure if it's my mail client but the above looks slightly mangled; in >>> any case the above addition shouldn't be needed because >>> core-image.bbclass already does this. >> >> Are you sure it counts? core-image.bbclass is included after this would be >> evaluated, or does that not matter? > > It doesn't matter in most cases, because the value won't actually be expanded > until later. Values aren't expanded unless you use immediate expansion (the := > operator) or you d.getVar("SOMEVAR", True) is called from python code to > return the expanded value. Understood, thanks. Should I send another patch with that line removed? -- ------------------------------------------------------------ Gary Thomas | Consulting for the MLB Associates | Embedded world ------------------------------------------------------------