From: Rongqing Li <rongqing.li@windriver.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] pseudo: fix library path in FILES_${PN}
Date: Thu, 31 Oct 2013 08:45:08 +0800 [thread overview]
Message-ID: <5271A814.3010301@windriver.com> (raw)
In-Reply-To: <1383129826.25877.16.camel@ted>
On 10/30/2013 06:43 PM, Richard Purdie wrote:
> On Tue, 2013-10-29 at 16:03 -0700, Khem Raj wrote:
>> On Mon, Oct 28, 2013 at 9:54 PM, <rongqing.li@windriver.com> wrote:
>>> -FILES_${PN} = "${libdir}/pseudo/lib*/libpseudo.so ${bindir}/* ${localstatedir}/pseudo ${prefix}/var/pseudo"
>>> -FILES_${PN}-dbg += "${libdir}/pseudo/lib*/.debug"
>>> +FILES_${PN} = "${prefix}/lib/pseudo/lib*/libpseudo.so ${bindir}/* ${localstatedir}/pseudo ${prefix}/var/pseudo"
>>> +FILES_${PN}-dbg += "${prefix}/lib/pseudo/lib*/.debug"
>>> +INSANE_SKIP_${PN} += "libdir"
>>> +INSANE_SKIP_${PN}-dbg += "libdir"
>>> +
>>
>> may be you can use ${nonarch_base_libdir} instead of hardcoding
>
> It is pointless using that expression if the path is hardcoded into the
> source though, which in this case, I suspect it is :(
>
> Cheers,
It is true, if we use ${nonarch_base_libdir}, we need to change the all:
lirq@lirq-OptiPlex-780:/home/prj/oe-core/meta/recipes-devtools/pseudo$
grep "${prefix}/lib" ./ -r
./pseudo.inc:FILES_${PN} = "${prefix}/lib/pseudo/lib*/libpseudo.so
${bindir}/* ${localstatedir}/pseudo ${prefix}/var/pseudo"
./pseudo.inc:FILES_${PN}-dbg += "${prefix}/lib/pseudo/lib*/.debug"
./pseudo.inc: ${S}/configure ${PSEUDO_EXTRA_OPTS} --prefix=${prefix}
--libdir=${prefix}/lib/pseudo/lib${SITEINFO_BITS}
--with-sqlite-lib=${baselib}
--with-sqlite=${STAGING_DIR_TARGET}${exec_prefix} --cflags="${CFLAGS}"
--bits=${SITEINFO_BITS} --enable-static-sqlite --without-rpath
./pseudo.inc: ${S}/configure ${PSEUDO_EXTRA_OPTS} --prefix=${prefix}
--libdir=${prefix}/lib/pseudo/lib --with-sqlite-lib=${baselib}
--with-sqlite=${STAGING_DIR_TARGET}${exec_prefix} --cflags="${CFLAGS}"
--bits=${SITEINFO_BITS} --enable-static-sqlite --without-rpath
./pseudo.inc: ./configure ${PSEUDO_EXTRA_OPTS} --prefix=${prefix}
--libdir=${prefix}/lib/pseudo/lib --with-sqlite-lib=${baselib}
--with-sqlite=${STAGING_DIR_TARGET}${exec_prefix} --bits=32 --without-rpath
./pseudo.inc: ./configure ${PSEUDO_EXTRA_OPTS} --prefix=${prefix}
--libdir=${prefix}/lib/pseudo/lib --with-sqlite-lib=${baselib}
--with-sqlite=${STAGING_DIR_TARGET}${exec_prefix} --bits=32 --without-rpath
./pseudo.inc: oe_runmake 'DESTDIR=${D}' ${MAKEOPTS}
'LIB=lib/pseudo/lib$(MARK64)' install
./pseudo.inc: mkdir -p ${D}${prefix}/lib/pseudo/lib
./pseudo.inc: cp lib/pseudo/lib/libpseudo.so ${D}${prefix}/lib/pseudo/lib/.
./pseudo.inc: mkdir -p ${D}${prefix}/lib/pseudo/lib
./pseudo.inc: cp lib/pseudo/lib/libpseudo.so ${D}${prefix}/lib/pseudo/lib/.
lirq@lirq-OptiPlex-780:/home/prj/oe-core/meta/recipes-devtools/pseudo$
-Roy
>
> Richard
>
>
>
--
Best Reagrds,
Roy | RongQing Li
prev parent reply other threads:[~2013-10-31 0:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 4:54 [PATCH] pseudo: fix library path in FILES_${PN} rongqing.li
2013-10-29 23:03 ` Khem Raj
2013-10-30 10:43 ` Richard Purdie
2013-10-31 0:45 ` Rongqing Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5271A814.3010301@windriver.com \
--to=rongqing.li@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox