From: Saul Wold <sgw@linux.intel.com>
To: Konrad Scherer <konrad.scherer@windriver.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] perf: Disable warnings as errors for kernels 3.1+
Date: Thu, 07 Nov 2013 15:16:19 -0800 [thread overview]
Message-ID: <527C1F43.2080105@linux.intel.com> (raw)
In-Reply-To: <1383849386-7680-2-git-send-email-konrad.scherer@windriver.com>
On 11/07/2013 10:36 AM, Konrad Scherer wrote:
> From: Konrad Scherer <Konrad.Scherer@windriver.com>
>
> Turns out the sed command has not been working as intended since
> kernel 3.1 due to the trailing space. Adding the WERROR=0 environment
> variable is the correct way to disable warnings as errors.
>
So, I recently saw this failure:
ERROR: Logfile of failure stored in:
/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/work/genericx86_64-poky-linux/perf/1.0-r8/temp/log.do_configure.12897
Log data follows:
| DEBUG: Executing python function sysroot_cleansstate
| DEBUG: Python function sysroot_cleansstate finished
| DEBUG: Executing shell function do_configure
| sed: can't read
/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/sysroots/genericx86-64/usr/src/kernel/tools/perf/Makefile:
No such file or directory
| WARNING:
/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/work/genericx86_64-poky-linux/perf/1.0-r8/temp/run.do_configure.12897:1
exit 2 from
| sed -i 's,-Werror ,,'
/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/sysroots/genericx86-64/usr/src/kernel/tools/perf/Makefile
| ERROR: Function failed: do_configure (log file is located at
/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-x86-64/build/build/tmp/work/genericx86_64-poky-linux/perf/1.0-r8/temp/log.do_configure.12897)
NOTE: recipe perf-1.0-r8: task do_configure: Failed
ERROR: Task 3469
(/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-x86-64/build/meta/recipes-kernel/perf/perf.bb,
do_configure) failed with exit code '1'
I am not sure that your patch will completely address this failure.
Sau!
> Signed-off-by: Konrad Scherer <Konrad.Scherer@windriver.com>
> ---
> meta/recipes-kernel/perf/perf.bb | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
> index 903ffa6..6258cbb 100644
> --- a/meta/recipes-kernel/perf/perf.bb
> +++ b/meta/recipes-kernel/perf/perf.bb
> @@ -41,6 +41,9 @@ export STAGING_LIBDIR
> export BUILD_SYS
> export HOST_SYS
>
> +#kernel 3.1+ supports WERROR to disable warnings as errors
> +export WERROR = "0"
> +
> do_populate_lic[depends] += "virtual/kernel:do_populate_sysroot"
>
> # needed for building the tools/perf Perl binding
> @@ -115,6 +118,7 @@ do_install() {
> }
>
> do_configure_prepend () {
> + #kernels before 3.1 do not support WERROR env variable
> sed -i 's,-Werror ,,' ${S}/tools/perf/Makefile
> }
>
>
next prev parent reply other threads:[~2013-11-07 23:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 18:36 [Patch 0/1] perf: Disable warnings as errors for kernels 3.1+ Konrad Scherer
2013-11-07 18:36 ` [PATCH] " Konrad Scherer
2013-11-07 23:16 ` Saul Wold [this message]
2013-11-08 2:59 ` Konrad Scherer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527C1F43.2080105@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=konrad.scherer@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox