From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <Yanjun.Zhu@windriver.com>
Received: from mail.windriver.com (mail.windriver.com [147.11.1.11])
	by mail.openembedded.org (Postfix) with ESMTP id 67C466D125
	for <openembedded-core@lists.openembedded.org>;
	Tue, 19 Nov 2013 08:40:07 +0000 (UTC)
Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com
	[147.11.189.40])
	by mail.windriver.com (8.14.5/8.14.5) with ESMTP id rAJ8e7bC020594
	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL);
	Tue, 19 Nov 2013 00:40:07 -0800 (PST)
Received: from [128.224.162.216] (128.224.162.216) by ALA-HCA.corp.ad.wrs.com
	(147.11.189.50) with Microsoft SMTP Server (TLS) id 14.2.347.0;
	Tue, 19 Nov 2013 00:40:06 -0800
Message-ID: <528B23E7.4030805@windriver.com>
Date: Tue, 19 Nov 2013 16:40:07 +0800
From: yzhu1 <Yanjun.Zhu@windriver.com>
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:24.0) Gecko/20100101 Thunderbird/24.0
MIME-Version: 1.0
To: Richard Purdie <richard.purdie@linuxfoundation.org>
References: <1384770701-30455-1-git-send-email-yanjun.zhu@windriver.com>
	<1384777206.6460.222.camel@ted>
In-Reply-To: <1384777206.6460.222.camel@ted>
X-Originating-IP: [128.224.162.216]
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] pr-util: insert appropriate parameter to adapt libtool
X-BeenThere: openembedded-core@lists.openembedded.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Patches and discussions about the oe-core layer
	<openembedded-core.lists.openembedded.org>
List-Unsubscribe: <http://lists.openembedded.org/mailman/options/openembedded-core>,
	<mailto:openembedded-core-request@lists.openembedded.org?subject=unsubscribe>
List-Archive: <http://lists.openembedded.org/pipermail/openembedded-core/>
List-Post: <mailto:openembedded-core@lists.openembedded.org>
List-Help: <mailto:openembedded-core-request@lists.openembedded.org?subject=help>
List-Subscribe: <http://lists.openembedded.org/mailman/listinfo/openembedded-core>,
	<mailto:openembedded-core-request@lists.openembedded.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Nov 2013 08:40:07 -0000
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

On 11/18/2013 08:20 PM, Richard Purdie wrote:
> On Mon, 2013-11-18 at 18:31 +0800, yanjun.zhu wrote:
>> When ccache is enabled, a parameter "ccache" is inserted.
>> libtool can not handle this parameter correctly. So "--tag=CC"
>> is introduced to help libtool handle it.
>> ---
>>   meta/recipes-support/apr/apr-util_1.5.2.bb |    5 +++++
>>   1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/meta/recipes-support/apr/apr-util_1.5.2.bb b/meta/recipes-support/apr/apr-util_1.5.2.bb
>> index ea0f7fb..d6ae394 100644
>> --- a/meta/recipes-support/apr/apr-util_1.5.2.bb
>> +++ b/meta/recipes-support/apr/apr-util_1.5.2.bb
>> @@ -34,6 +34,11 @@ do_configure_append() {
>>   	if [ "${CLASSOVERRIDE}" = "class-target" ]; then
>>   		cp ${STAGING_DATADIR}/apr/apr_rules.mk ${S}/build/rules.mk
>>   	fi
>> +
>> +	# When ccache is enabled, libtool needs --tag=CC to choose correct handle methods.
>> +	if [ -f ${S}/build/rules.mk ]; then
>> +		sed -i "s,^LTFLAGS,LTFLAGS      = --silent --tag=CC\n#LTFLAGS,g" ${S}/build/rules.mk
>> +	fi
>>   }
>>   do_configure_prepend_class-native() {
>>   	cp ${STAGING_DATADIR_NATIVE}/apr/apr_rules.mk ${S}/build/rules.mk
> This looks like something better done with a specific patch along with
> an explanation in the patch header. Is there any reason upstream
> wouldn't do this?
>
> By using a patch we ensure that when things are upgraded, the right
> thing still gets done. You may need to update the apr recipe itself to
> get the patch right.
>
> Cheers,
>
> Richard
>
Hi, Richard

rules.mk is copied from apr_rules.mk. apr_rules.mk is generated by 
configure task.
The configure task is after patch. So it is difficult to make a patch 
for this defect.

Best Regards!
Zhu Yanjun
>