From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mail.openembedded.org (Postfix) with ESMTP id CA15C6C741 for ; Thu, 21 Nov 2013 18:49:43 +0000 (UTC) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 21 Nov 2013 10:49:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.93,746,1378882800"; d="scan'208";a="437509373" Received: from unknown (HELO [10.255.15.149]) ([10.255.15.149]) by fmsmga002.fm.intel.com with ESMTP; 21 Nov 2013 10:49:37 -0800 Message-ID: <528E55C1.6030904@linux.intel.com> Date: Thu, 21 Nov 2013 10:49:37 -0800 From: Saul Wold User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: qiang.chen@windriver.com, openembedded-core@lists.openembedded.org References: <1385025291-14853-1-git-send-email-qiang.chen@windriver.com> In-Reply-To: <1385025291-14853-1-git-send-email-qiang.chen@windriver.com> Subject: Re: [PATCH] shadow: remove reference to locale env files from su X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2013 18:49:43 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 11/21/2013 01:14 AM, qiang.chen@windriver.com wrote: > From: Qiang Chen > > The /etc/default/locale missing message appears when running su > > root@qemu0:/var/log# su root > root@qemu0:/var/log# tail auth.log > Oct 8 07:47:54 qemu0 login[983]: pam_unix(login:session): session opened for user root by LOGIN(uid=0) > Oct 8 07:47:55 qemu0 login[995]: ROOT LOGIN on '/dev/console' > Oct 8 07:48:21 qemu0 su[999]: Successful su for root by root > Oct 8 07:48:21 qemu0 su[999]: + /dev/console root:root > Oct 8 07:48:21 qemu0 su[999]: pam_env(su:session): Unable to open env file: /etc/default/locale: No such file or directory > Oct 8 07:48:21 qemu0 su[999]: pam_unix(su:session): session opened for user root by root(uid=0) > > This commit remove reference from pam.d/su to /etc/default/locale > env file to avoid the error messages. > > Signed-off-by: Qiang Chen > --- > meta/recipes-extended/shadow/files/pam.d/su | 3 --- > meta/recipes-extended/shadow/shadow.inc | 2 +- > 2 files changed, 1 insertion(+), 4 deletions(-) > > diff --git a/meta/recipes-extended/shadow/files/pam.d/su b/meta/recipes-extended/shadow/files/pam.d/su > index 8e35137..8d590a3 100644 > --- a/meta/recipes-extended/shadow/files/pam.d/su > +++ b/meta/recipes-extended/shadow/files/pam.d/su > @@ -34,9 +34,6 @@ auth sufficient pam_rootok.so > # > # parsing /etc/environment needs "readenv=1" > session required pam_env.so readenv=1 > -# locale variables are also kept into /etc/default/locale in etch > -# reading this file *in addition to /etc/environment* does not hurt > -session required pam_env.so readenv=1 envfile=/etc/default/locale > Should we be providing an empty locale file instead, what happens if someone wants to use the locale mechanism? > # Defines the MAIL environment variable > # However, userdel also needs MAIL_DIR and MAIL_FILE variables > diff --git a/meta/recipes-extended/shadow/shadow.inc b/meta/recipes-extended/shadow/shadow.inc > index 5ab978a..572c3bc 100644 > --- a/meta/recipes-extended/shadow/shadow.inc > +++ b/meta/recipes-extended/shadow/shadow.inc > @@ -44,7 +44,7 @@ SRC_URI_append_class-nativesdk = " \ > SRC_URI[md5sum] = "b8608d8294ac88974f27b20f991c0e79" > SRC_URI[sha256sum] = "633f5bb4ea0c88c55f3642c97f9d25cbef74f82e0b4cf8d54e7ad6f9f9caa778" > > -PR = "r13" > +PR = "r14" > No more PR bumps please. Sau! > # Additional Policy files for PAM > PAM_SRC_URI = "file://pam.d/chfn \ >