From: jhuang0 <jackie.huang@windriver.com>
To: yzhu1 <yanjun.zhu@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] populate_sdk: verify executable or dynamically linked library
Date: Tue, 26 Nov 2013 16:39:14 +0800 [thread overview]
Message-ID: <52945E32.2000403@windriver.com> (raw)
In-Reply-To: <1385454283-25126-1-git-send-email-yanjun.zhu@windriver.com>
On 11/26/2013 4:24 PM, yzhu1 wrote:
> When toolchain directory is changed to execute mode, some non-executable
> files or empty files are sorted. This will result in some errors. Thus when
> sorting executable files or dynamically linked library, additional conditions
> are to exclude non-executable files or empty files.
> ---
> meta/classes/populate_sdk_base.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/populate_sdk_base.bbclass b/meta/classes/populate_sdk_base.bbclass
> index b7ea851..6b3535d 100644
> --- a/meta/classes/populate_sdk_base.bbclass
> +++ b/meta/classes/populate_sdk_base.bbclass
> @@ -253,7 +253,7 @@ if [ "$dl_path" = "" ] ; then
> echo "SDK could not be set up. Relocate script unable to find ld-linux.so. Abort!"
> exit 1
> fi
> -executable_files=$($SUDO_EXEC find $native_sysroot -type f -perm /111)
> +executable_files=$($SUDO_EXEC find $native_sysroot -type f -perm +111 -exec file '{}' \;| grep "\(executable\|dynamically linked\)" | cut -f 1 -d ':')
You should not change the -perm option back to use +mode, please refer to:
commit 21b079e01873e2fb4d8674541e8c5818ba73554e
Author: Stefan Stanacar <stefanx.stanacar@intel.com>
Date: Tue Jul 16 14:42:35 2013 +0300
populate_sdk_base.bbclass: use new perm option for find
Old way find -perm +mode is no longer supported in newer
versions of find (Fedora 19). Man page says:
-perm +mode
This is no longer supported (and has been deprecated since
2005). Use -perm /mode instead.
[YOCTO #4853]
Signed-off-by: Stefan Stanacar <stefanx.stanacar@intel.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Thanks,
Jackie
>
> tdir=`mktemp -d`
> if [ x$tdir = x ] ; then
>
next prev parent reply other threads:[~2013-11-26 8:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 8:24 [PATCH] populate_sdk: verify executable or dynamically linked library yzhu1
2013-11-26 8:39 ` yzhu1
2013-11-26 8:39 ` jhuang0 [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-11-26 8:38 yzhu1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52945E32.2000403@windriver.com \
--to=jackie.huang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=yanjun.zhu@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox