From: Bruce Ashfield <bruce.ashfield@windriver.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] Revert "kernel: restore scripts in the sysroot"
Date: Wed, 27 Nov 2013 08:46:23 -0500 [thread overview]
Message-ID: <5295F7AF.1000506@windriver.com> (raw)
In-Reply-To: <1385559899.11222.0.camel@ted>
On 13-11-27 08:44 AM, Richard Purdie wrote:
> This reverts commit 6a6735cb98d529c8c5376aedb5c951339f54fe96.
>
> The module class already ensures the scripts are rebuilt correctly. Running
> this at sstate installation time is problematic since it can require the
> cross compiler. Adding such a dependency would cause issues of its own.
I was waiting for the dust to clear and have been running with the
same thing here, saves me from sending it and I've removed it from
my queue.
Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 4974507..24ac778 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -290,17 +290,6 @@ kernel_do_install() {
> }
> do_install[prefuncs] += "package_get_auto_pr"
>
> -
> -SSTATEPOSTINSTFUNCS += "kernelscripts_sstate_postinst"
> -kernelscripts_sstate_postinst () {
> - if [ "${BB_CURRENTTASK}" = "populate_sysroot" -o "${BB_CURRENTTASK}" = "populate_sysroot_setscene" ]; then
> - (
> - cd ${STAGING_KERNEL_DIR}
> - oe_runmake scripts
> - )
> - fi
> -}
> -
> python sysroot_stage_all () {
> oe.path.copyhardlinktree(d.expand("${D}${KERNEL_SRC_PATH}"), d.expand("${SYSROOT_DESTDIR}${KERNEL_SRC_PATH}"))
> }
>
>
next prev parent reply other threads:[~2013-11-27 13:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 13:44 [PATCH] Revert "kernel: restore scripts in the sysroot" Richard Purdie
2013-11-27 13:46 ` Bruce Ashfield [this message]
2013-11-27 15:43 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5295F7AF.1000506@windriver.com \
--to=bruce.ashfield@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox