Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Ming Liu <ming.liu@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] gzip: fix MakeMaker issues with using wrong SHELL/GREP
Date: Fri, 29 Nov 2013 16:36:55 +0800	[thread overview]
Message-ID: <52985227.8040603@windriver.com> (raw)
In-Reply-To: <1385634389-31914-1-git-send-email-ming.liu@windriver.com>

On 11/28/2013 06:26 PM, Ming Liu wrote:
> Paths of shell/grep is being determined by detecting from host at configure
> stage, and then will be hard coded into scripts like zgrep, this would
> cause a following runtime error:
> "/usr/bin/zgrep: line 230: /usr/bin/grep: No such file or directory"
>
> Fixed by using runtime paths instead.
>
> Signed-off-by: Ming Liu <ming.liu@windriver.com>
> ---
>   meta/recipes-extended/gzip/gzip.inc | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/meta/recipes-extended/gzip/gzip.inc b/meta/recipes-extended/gzip/gzip.inc
> index 6ec1dae..4b265a6 100644
> --- a/meta/recipes-extended/gzip/gzip.inc
> +++ b/meta/recipes-extended/gzip/gzip.inc
> @@ -12,6 +12,11 @@ SRC_URI = "${GNU_MIRROR}/gzip/${BP}.tar.gz"
>   
>   inherit autotools
>   
> +do_configure_prepend () {
> +	sed '\#|/bin/sh|\$(SHELL)|#d' -i Makefile.am
> +	sed 's#\(|\[@\]GREP@|\)\$(GREP)#\1/bin/grep#g' -i Makefile.am
There is a hardcode /bin/grep here, should be removed, and I am told 
it's better to use patch instead of prepending to do_configure task, so 
I will send the V2 soon.

//Ming Liu
> +}
> +
>   do_install_append () {
>   	# Rename and move files into /bin (FHS), which is typical place for gzip
>   	install -d ${D}${base_bindir}



  reply	other threads:[~2013-11-29  8:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-28 10:26 [PATCH] gzip: fix MakeMaker issues with using wrong SHELL/GREP Ming Liu
2013-11-29  8:36 ` Ming Liu [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-11-21  9:50 jackie.huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52985227.8040603@windriver.com \
    --to=ming.liu@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox