Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Hongxu Jia <hongxu.jia@windriver.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: saul.wold@intel.com, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 3/3] eglibc-locale.inc: use nativesdk override with the PACKAGES_DYNAMIC statement
Date: Wed, 4 Dec 2013 11:15:00 +0800	[thread overview]
Message-ID: <529E9E34.10806@windriver.com> (raw)
In-Reply-To: <1386072858.4463.42.camel@ted>

Hi Richard,

I have updated this patch as your suggestion, and it works well.

     nativesdk.bbclass: support nativesdk to override with the 
PACKAGES_DYNAMIC statement

     While compiling nativesdk-mtools, there was failure:
     ...
     Nothing PROVIDES 'nativesdk-glibc-gconv-ibm850'. Close matches:
     ...
     This patch supports nativesdk to override with the PACKAGES_DYNAMIC 
statement

     [YOCTO #5623]
     Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>

diff --git a/meta/classes/nativesdk.bbclass b/meta/classes/nativesdk.bbclass
index 94bc326..21a69c7 100644
--- a/meta/classes/nativesdk.bbclass
+++ b/meta/classes/nativesdk.bbclass
@@ -81,6 +81,7 @@ python () {
      clsextend.map_depends_variable("DEPENDS")
      clsextend.map_packagevars()
      clsextend.map_variable("PROVIDES")
+    clsextend.map_regexp_variable("PACKAGES_DYNAMIC")
  }

//Hongxu

On 12/03/2013 08:14 PM, Richard Purdie wrote:
> On Tue, 2013-12-03 at 18:27 +0800, Hongxu Jia wrote:
>> While compiling nativesdk-mtools, there was failure:
>> ...
>> Nothing PROVIDES 'nativesdk-glibc-gconv-ibm850'. Close matches:
>> ...
>>
>> Using nativesdk override with the PACKAGES_DYNAMIC statement fixed this issue.
>>
>> [YOCTO #5623]
>>
>> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
>> ---
>>   meta/recipes-core/eglibc/eglibc-locale.inc | 6 ++++++
>>   1 file changed, 6 insertions(+)
> No.
>
> lib/oe/classextend.py has a map_regexp_variable() function which is
> called from classes/multilib.bbclass:
>
> clsextend.map_regexp_variable("PACKAGES_DYNAMIC")
>
> Perhaps such a line should be added to nativesdk.bbclass to fix this
> properly instead?
>
> Cheers,
>
> Richard
>
>> diff --git a/meta/recipes-core/eglibc/eglibc-locale.inc b/meta/recipes-core/eglibc/eglibc-locale.inc
>> index 83569da..5e256a5 100644
>> --- a/meta/recipes-core/eglibc/eglibc-locale.inc
>> +++ b/meta/recipes-core/eglibc/eglibc-locale.inc
>> @@ -35,6 +35,12 @@ PACKAGES_DYNAMIC = "^locale-base-.* \
>>                       ^eglibc-gconv-.* ^eglibc-charmap-.* ^eglibc-localedata-.* ^eglibc-binary-localedata-.* \
>>                       ^glibc-gconv-.*  ^glibc-charmap-.*  ^glibc-localedata-.*  ^glibc-binary-localedata-.*"
>>   
>> +PACKAGES_DYNAMIC_class-nativesdk = "^nativesdk-locale-base-.* \
>> +                    ^nativesdk-eglibc-gconv-.* ^nativesdk-eglibc-charmap-.* \
>> +                    ^nativesdk-eglibc-localedata-.* ^nativesdk-eglibc-binary-localedata-.* \
>> +                    ^nativesdk-glibc-gconv-.*  ^nativesdk-glibc-charmap-.*  \
>> +                    ^nativesdk-glibc-localedata-.*  ^nativesdk-glibc-binary-localedata-.*"
>> +
>>   # Create a eglibc-binaries package
>>   ALLOW_EMPTY_${BPN}-binaries = "1"
>>   PACKAGES += "${BPN}-binaries"
>



  reply	other threads:[~2013-12-04  3:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-03 10:27 [PATCH 0/3] mtools, syslinux: add ability to compile with nativesdk Hongxu Jia
2013-12-03 10:27 ` [PATCH 1/3] mtools: " Hongxu Jia
2013-12-03 10:27 ` [PATCH 2/3] syslinux: " Hongxu Jia
2013-12-03 10:27 ` [PATCH 3/3] eglibc-locale.inc: use nativesdk override with the PACKAGES_DYNAMIC statement Hongxu Jia
2013-12-03 12:14   ` Richard Purdie
2013-12-04  3:15     ` Hongxu Jia [this message]
2013-12-10  4:39       ` Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=529E9E34.10806@windriver.com \
    --to=hongxu.jia@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    --cc=saul.wold@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox