Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Andrei Gherzan <andrei@gherzan.ro>,
	 openembedded-core@lists.openembedded.org
Subject: Re: [PATCH V2][ 2/2] libav: Update to v0.8.9
Date: Thu, 05 Dec 2013 11:25:53 -0800	[thread overview]
Message-ID: <52A0D341.7090007@linux.intel.com> (raw)
In-Reply-To: <1386234101-21411-2-git-send-email-andrei@gherzan.ro>


Andrei:

I see RP already merged this, but I have a couple of comments


On 12/05/2013 01:01 AM, Andrei Gherzan wrote:
> Signed-off-by: Andrei Gherzan <andrei@gherzan.ro>
> ---
>   .../0001-configure-enable-pic-for-AArch64.patch                   | 0
>   meta/recipes-multimedia/libav/{libav_0.8.8.bb => libav_0.8.9.bb}  | 8 +++-----
>   2 files changed, 3 insertions(+), 5 deletions(-)
>   rename meta/recipes-multimedia/libav/{libav-0.8.8 => libav-0.8.9}/0001-configure-enable-pic-for-AArch64.patch (100%)
>   rename meta/recipes-multimedia/libav/{libav_0.8.8.bb => libav_0.8.9.bb} (69%)
>
> diff --git a/meta/recipes-multimedia/libav/libav-0.8.8/0001-configure-enable-pic-for-AArch64.patch b/meta/recipes-multimedia/libav/libav-0.8.9/0001-configure-enable-pic-for-AArch64.patch
> similarity index 100%
> rename from meta/recipes-multimedia/libav/libav-0.8.8/0001-configure-enable-pic-for-AArch64.patch
> rename to meta/recipes-multimedia/libav/libav-0.8.9/0001-configure-enable-pic-for-AArch64.patch

We are generally trying to get rid of versioned patch directory in favor 
of just a general recipe name (libav in this case).

> diff --git a/meta/recipes-multimedia/libav/libav_0.8.8.bb b/meta/recipes-multimedia/libav/libav_0.8.9.bb
> similarity index 69%
> rename from meta/recipes-multimedia/libav/libav_0.8.8.bb
> rename to meta/recipes-multimedia/libav/libav_0.8.9.bb
> index 9cb4cf2..065a6d2 100644
> --- a/meta/recipes-multimedia/libav/libav_0.8.8.bb
> +++ b/meta/recipes-multimedia/libav/libav_0.8.9.bb
> @@ -1,10 +1,10 @@
>   require libav.inc
>
> -SRC_URI = "http://libav.org/releases/libav-0.8.8.tar.xz \
> +SRC_URI = "http://libav.org/releases/libav-0.8.9.tar.xz \
why not convert this to ${BP} so it does not need to be edited in the 
future. BP = BPN-PV.

Sau!

>              file://0001-configure-enable-pic-for-AArch64.patch"
>
> -SRC_URI[md5sum] = "34b8f1279a04466386ed67731197efe3"
> -SRC_URI[sha256sum] = "e95cf618eb6239177a62c46f15e840c37e02e8308baf94912fc5910ff4aacbf2"
> +SRC_URI[md5sum] = "7c0e5743cd5c4d4b1bcafd02a2e82e09"
> +SRC_URI[sha256sum] = "4f5181164e4007d5b0013bb3cc5e3b7393ab71ac286319c714b7697e2784f77f"
>
>   LIC_FILES_CHKSUM = "file://COPYING.GPLv2;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
>                       file://COPYING.GPLv3;md5=d32239bcb673463ab874e80d47fae504 \
> @@ -14,5 +14,3 @@ LIC_FILES_CHKSUM = "file://COPYING.GPLv2;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
>   EXTRA_OECONF += " \
>       --enable-postproc \
>   "
> -
> -
>


  reply	other threads:[~2013-12-05 19:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-05  9:01 [PATCH V2][ 1/2] libav: Add v9.10 Andrei Gherzan
2013-12-05  9:01 ` [PATCH V2][ 2/2] libav: Update to v0.8.9 Andrei Gherzan
2013-12-05 19:25   ` Saul Wold [this message]
2013-12-07 18:01     ` Andrei Gherzan
2013-12-05 19:53 ` [PATCH V2][ 1/2] libav: Add v9.10 Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A0D341.7090007@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=andrei@gherzan.ro \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox