From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by mail.openembedded.org (Postfix) with ESMTP id 34BB66DFD0 for ; Thu, 5 Dec 2013 23:18:57 +0000 (UTC) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by azsmga101.ch.intel.com with ESMTP; 05 Dec 2013 15:18:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.93,836,1378882800"; d="scan'208";a="439392852" Received: from jbrandeb-mobl.amr.corp.intel.com (HELO [10.255.15.213]) ([10.255.15.213]) by fmsmga001.fm.intel.com with ESMTP; 05 Dec 2013 15:18:55 -0800 Message-ID: <52A109DF.5030308@linux.intel.com> Date: Thu, 05 Dec 2013 15:18:55 -0800 From: Saul Wold User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Hongxu Jia , openembedded-core@lists.openembedded.org References: <3177e964cb6b15eebb3c6d26360c9028feace1ed.1385039538.git.hongxu.jia@windriver.com> <528FDAF9.1070809@linux.intel.com> <52900B3B.8030909@windriver.com> <52900CCE.5080709@windriver.com> In-Reply-To: <52900CCE.5080709@windriver.com> Subject: Re: [PATCH 3/4] lttng-tools: add PACKAGECONFIG to support --enable-python-bindings and lttng-ust X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Dec 2013 23:18:57 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 11/22/2013 06:02 PM, Hongxu Jia wrote: > On 11/23/2013 09:56 AM, Hongxu Jia wrote: >> On 11/23/2013 06:30 AM, Saul Wold wrote: >>> On 11/21/2013 05:14 AM, Hongxu Jia wrote: >>>> Add PACKAGECONFIG to support --enable-python-bindings >>>> Add PACKAGECONFIG to support lttng-ust >>>> >>>> Signed-off-by: Hongxu Jia >>>> --- >>>> meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb | 20 >>>> ++++++++++++++++---- >>>> 1 file changed, 16 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb >>>> b/meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb >>>> index 2f6e504..64b6e02 100644 >>>> --- a/meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb >>>> +++ b/meta/recipes-kernel/lttng/lttng-tools_2.3.1.bb >>>> @@ -9,9 +9,18 @@ LIC_FILES_CHKSUM = >>>> "file://LICENSE;md5=01d7fc4496aacf37d90df90b90b0cac1 \ >>>> file://gpl-2.0.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263 \ >>>> file://lgpl-2.1.txt;md5=0f0d71500e6a57fd24d825f33242b9ca" >>>> >>>> -DEPENDS = "liburcu popt lttng-ust" >>>> +DEPENDS = "liburcu popt" >>>> RDEPENDS_${PN}-ptest += "make" >>>> >>>> +PYTHON_OPTION = >>>> "am_cv_python_pyexecdir='${libdir}/python${PYTHON_BASEVERSION}/site-packages' >>>> \ >>>> + >>>> am_cv_python_pythondir='${libdir}/python${PYTHON_BASEVERSION}/site-packages' >>>> \ >>>> + PYTHON_INCLUDE='-I${STAGING_INCDIR}/python${PYTHON_BASEVERSION}' \ >>>> +" >>>> +PACKAGECONFIG = "python lttng-ust" >>>> +PACKAGECONFIG[python] = "--enable-python-bindings ${PYTHON_OPTION}, \ >>>> + --disable-python-bindings, python >>>> swig-native" >>> >>> This seems to bring in a new dependency on "swig", which is not part >>> of OE-Core. >>> >> >> Oh, The Windriver Linux have swig by default, we should >> disable python for OE-Core. >> >> s/PACKAGECONFIG = "python lttng-ust" /PACKAGECONFIG ??= "lttng-ust"/ >> > > Have updated the git tree to do this. > There still seems to be an issue with this patch, but it might be a problem with lttng-tool's configure.ac. When --disable-python-bindings is set, it still tries to check for SWIG (which you might have in your build). Please verify this. Thanks > //Hongxu > > >> //Hongxu >>> Sau! >>> >>>> +PACKAGECONFIG[lttng-ust] = "--enable-lttng-ust, >>>> --disable-lttng-ust, lttng-ust" >>>> + >>>> SRCREV = "5d985544a7ad54afa0514ea7f522a89d8d844860" >>>> PV = "v2.3.1" >>>> >>>> @@ -26,12 +35,15 @@ inherit autotools ptest >>>> >>>> export KERNELDIR="${STAGING_KERNEL_DIR}" >>>> >>>> -FILES_${PN} += "${libdir}/lttng/libexec/*" >>>> -FILES_${PN}-dbg += "${libdir}/lttng/libexec/.debug" >>>> +FILES_${PN} += "${libdir}/lttng/libexec/* >>>> ${libdir}/python${PYTHON_BASEVERSION}/site-packages/*" >>>> +FILES_${PN}-dbg += "${libdir}/lttng/libexec/.debug >>>> ${libdir}/python2.7/site-packages/.debug" >>>> +FILES_${PN}-staticdev += >>>> "${libdir}/python${PYTHON_BASEVERSION}/site-packages/*.a" >>>> +FILES_${PN}-dev += >>>> "${libdir}/python${PYTHON_BASEVERSION}/site-packages/*.la" >>>> >>>> # Since files are installed into ${libdir}/lttng/libexec we match >>>> # the libexec insane test so skip it. >>>> -INSANE_SKIP_${PN} = "libexec" >>>> +# Python module needs to keep _lttng.so >>>> +INSANE_SKIP_${PN} = "libexec dev-so" >>>> INSANE_SKIP_${PN}-dbg = "libexec" >>>> >>>> >>>> >>> >> >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-core > > >