From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by mail.openembedded.org (Postfix) with ESMTP id E86A66DAAA for ; Tue, 10 Dec 2013 09:15:42 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.14.5/8.14.5) with ESMTP id rBA9FeLi029685 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Tue, 10 Dec 2013 01:15:40 -0800 (PST) Received: from [128.224.162.242] (128.224.162.242) by ALA-HCA.corp.ad.wrs.com (147.11.189.40) with Microsoft SMTP Server id 14.2.347.0; Tue, 10 Dec 2013 01:15:39 -0800 Message-ID: <52A6DBB9.50700@windriver.com> Date: Tue, 10 Dec 2013 17:15:37 +0800 From: Robert Yang User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Steffen Sledz , References: <1385647771-24485-1-git-send-email-sledz@dresearch-fe.de> <52A5D813.8020803@dresearch-fe.de> In-Reply-To: <52A5D813.8020803@dresearch-fe.de> Subject: Re: [PATCH][for-dora] gdb-7.6: fix cygwin check in configure script X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Dec 2013 09:15:45 -0000 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Thanks, applied to dora-next. // Robert On 12/09/2013 10:47 PM, Steffen Sledz wrote: > On 28.11.2013 15:09, Steffen Sledz wrote: >> This is a fix which avoids false positives if the search pattern >> "lose" is found in path descriptions in comments generated by the >> preprocessor we hit in our development environment. >> >> [gdb Bug #16152] -- https://sourceware.org/bugzilla/show_bug.cgi?id=16152 >> >> Upstream-Status: Accepted >> Signed-off-by: Steffen Sledz >> --- >> meta/recipes-devtools/gdb/gdb-7.6.inc | 2 ++ >> .../gdb-fix-cygwin-check-in-configure-script.patch | 38 ++++++++++++++++++++++ >> 2 files changed, 40 insertions(+) >> create mode 100644 meta/recipes-devtools/gdb/gdb/gdb-fix-cygwin-check-in-configure-script.patch >> >> diff --git a/meta/recipes-devtools/gdb/gdb-7.6.inc b/meta/recipes-devtools/gdb/gdb-7.6.inc >> index 00cb6ee..9be94b8 100644 >> --- a/meta/recipes-devtools/gdb/gdb-7.6.inc >> +++ b/meta/recipes-devtools/gdb/gdb-7.6.inc >> @@ -4,6 +4,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \ >> file://COPYING3.LIB;md5=6a6a8e020838b23406c81b19c1d46df6 \ >> file://COPYING.LIB;md5=9f604d8a4f8e74f4f5140845a21b6674" >> >> +SRC_URI += " file://gdb-fix-cygwin-check-in-configure-script.patch " >> + >> S = "${WORKDIR}/${BPN}-${PV}" >> >> SRC_URI[md5sum] = "a9836707337e5f7bf76a009a8904f470" >> diff --git a/meta/recipes-devtools/gdb/gdb/gdb-fix-cygwin-check-in-configure-script.patch b/meta/recipes-devtools/gdb/gdb/gdb-fix-cygwin-check-in-configure-script.patch >> new file mode 100644 >> index 0000000..4e4647b >> --- /dev/null >> +++ b/meta/recipes-devtools/gdb/gdb/gdb-fix-cygwin-check-in-configure-script.patch >> @@ -0,0 +1,38 @@ >> +Avoid false positives if the search pattern "lose" is found in path >> +descriptions in comments generated by the preprocessor. >> + >> +See . >> +--- >> + gdb/configure | 2 +- >> + gdb/configure.ac | 2 +- >> + 3 files changed, 7 insertions(+), 2 deletions(-) >> + >> +diff --git a/gdb/configure b/gdb/configure >> +index 5514b2f..b38e183 100755 >> +--- a/gdb/configure >> ++++ b/gdb/configure >> +@@ -12446,7 +12446,7 @@ lose >> + #endif >> + _ACEOF >> + if (eval "$ac_cpp conftest.$ac_ext") 2>&5 | >> +- $EGREP "lose" >/dev/null 2>&1; then : >> ++ $EGREP "^lose$" >/dev/null 2>&1; then : >> + gdb_cv_os_cygwin=yes >> + else >> + gdb_cv_os_cygwin=no >> +diff --git a/gdb/configure.ac b/gdb/configure.ac >> +index 9b73887..2947293 100644 >> +--- a/gdb/configure.ac >> ++++ b/gdb/configure.ac >> +@@ -1877,7 +1877,7 @@ AC_SUBST(WERROR_CFLAGS) >> + >> + # In the Cygwin environment, we need some additional flags. >> + AC_CACHE_CHECK([for cygwin], gdb_cv_os_cygwin, >> +-[AC_EGREP_CPP(lose, [ >> ++[AC_EGREP_CPP(^lose$, [ >> + #if defined (__CYGWIN__) || defined (__CYGWIN32__) >> + lose >> + #endif],[gdb_cv_os_cygwin=yes],[gdb_cv_os_cygwin=no])]) >> +-- >> +1.8.4 >> + >> > > Ping! > > Robert, are you still there? >