From: ChenQi <Qi.Chen@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/3] image.bbclass: remove zap_root_password
Date: Wed, 11 Dec 2013 11:19:51 +0800 [thread overview]
Message-ID: <52A7D9D7.1090408@windriver.com> (raw)
In-Reply-To: <52A734FC.4020306@windriver.com>
On 12/10/2013 11:36 PM, Mark Hatle wrote:
> On 12/10/13, 6:15 AM, Paul Eggleton wrote:
>> Hi Qi,
>>
>> On Tuesday 10 December 2013 17:58:51 Qi.Chen@windriver.com wrote:
>>> From: Chen Qi <Qi.Chen@windriver.com>
>>>
>>> This function replaces the root password with '*' if 'debug-tweaks'
>>> is not in IMAGE_FEATURES. As a result, if we don't have 'debug-tweaks',
>>> we would be locked out of the system. That means, if the user uses a
>>> bbappend file for base-passwd to set the root password, he would not be
>>> able to login as root; if the user uses 'EXTRA_USERS_PARAMS' to set
>>> the root password, he would still not be able to login as root.
>>>
>>> In a word, this function should be removed to make things work
>>> correctly.
>>
>> Er, unless I'm missing something about what you're adding in the
>> other patch,
>> you *cannot* simply remove this. The intentional design of the
>> existing code
>> is that having "debug-tweaks" in IMAGE_FEATURES means that you can
>> log in as
>> root with no password; but most importantly if "debug-tweaks" is not
>> present
>> you cannot log in at all as root (in the absence of anything that
>> sets the
>> root password, of course). Any changes must preserve this behaviour.
>
> I agree. The default behavior on most systems should be absolutely no
> way to directly login as root. Instead logins should occur based on a
> non-privileged user. (The other patches in that set look good to me.)
>
> --Mark
>
>> Cheers,
>> Paul
>>
>
Mark & Paul,
Thanks for your explanation.
I think what we really want is to disallow *empty* root password if
'debug-tweaks' is not in IMAGE_FEATRUES. And if the root password has
already been set (via bbappend file or via EXTRA_USERS_PARAMS), we
should not zap that password. Maybe the function should be
zap_empty_root_password?
What do you think?
Best Regards,
Chen Qi
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
next prev parent reply other threads:[~2013-12-11 3:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 9:58 [PATCH 0/3] Add ability to set clear text password and remove zap_root_password function Qi.Chen
2013-12-10 9:58 ` [PATCH 1/3] shadow-native: allow for setting password in clear text Qi.Chen
2013-12-10 9:58 ` [PATCH 2/3] image.bbclass: remove zap_root_password Qi.Chen
2013-12-10 12:15 ` Paul Eggleton
2013-12-10 15:36 ` Mark Hatle
2013-12-11 3:19 ` ChenQi [this message]
2013-12-10 9:58 ` [PATCH 3/3] useradd-example: add example for setting clear text password Qi.Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A7D9D7.1090408@windriver.com \
--to=qi.chen@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox