Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Yasir Khan <yasir_khan@mentor.com>,
	 openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] openssl_1.0.1e: Install c_rehash utility with openssl
Date: Fri, 13 Dec 2013 10:43:40 -0800	[thread overview]
Message-ID: <52AB555C.6050705@linux.intel.com> (raw)
In-Reply-To: <1386958134-20626-1-git-send-email-yasir_khan@mentor.com>

On 12/13/2013 10:08 AM, Yasir Khan wrote:
> From: mykhani <yasir_khan@mentor.com>
>
> c_rehash utility is not being installed with openssl. It conveniently
> generates hash and symbolic links based on it for CA certificates
> stored locally for SSL based server authentication
>
> Signed-off-by: mykhani <yasir_khan@mentor.com>
> ---
>   meta/recipes-connectivity/openssl/openssl_1.0.1e.bb |   10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/meta/recipes-connectivity/openssl/openssl_1.0.1e.bb b/meta/recipes-connectivity/openssl/openssl_1.0.1e.bb
> index ac27dba..f52877c 100644
> --- a/meta/recipes-connectivity/openssl/openssl_1.0.1e.bb
> +++ b/meta/recipes-connectivity/openssl/openssl_1.0.1e.bb
> @@ -4,6 +4,9 @@ require openssl.inc
>   # if they are available.
>   DEPENDS += "ocf-linux"
>
> +# Perl is needed for the c_rehash script
> +RDEPENDS_${PN} += "perl"
> +
>   CFLAG += "-DHAVE_CRYPTODEV -DUSE_CRYPTODEV_DIGESTS"
>
>   PR = "${INC_PR}.0"
> @@ -53,3 +56,10 @@ PARALLEL_MAKEINST = ""
>   do_configure_prepend() {
>     cp ${WORKDIR}/find.pl ${S}/util/find.pl
>   }
> +
> +do_install_append() {
> +    # The c_rehash utility isn't being installed by the normal installation process.
> +    # It conveniently generates both hash and symbolic links based on hash for CA certificates.
> +    install -m 0755 ${S}/tools/c_rehash ${D}${bindir}
> +}
> +
Let's package this in a separate package such as ${PN}-misc, and then 
the perl dependency can be for that package only, I see that -misc 
already has some perl scripts but no RDEPENDS (it really should).

I am not sure that this tool and perl will be wanted on on embedded 
machines using openssl.

Also, I think this can go in the openssl.inc file instead of the .bb

Sau!

Sau!

>


      reply	other threads:[~2013-12-13 18:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-13 18:08 [PATCH] openssl_1.0.1e: Install c_rehash utility with openssl Yasir Khan
2013-12-13 18:43 ` Saul Wold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52AB555C.6050705@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=yasir_khan@mentor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox