Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Trevor Woerner <trevor.woerner@linaro.org>
To: Ross Burton <ross.burton@intel.com>,
	 openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/2] libmatchbox: use PACKAGECONFIG
Date: Sat, 14 Dec 2013 09:18:56 -0500	[thread overview]
Message-ID: <52AC68D0.1040208@linaro.org> (raw)
In-Reply-To: <1386677617-20952-2-git-send-email-ross.burton@intel.com>

Hi Ross,

Your commit message and your commit don't seem to agree. I.e. you say
you've removed 2 dependencies, but it looks like you've actually removed
more than just 2.

On 12/10/13 07:13, Ross Burton wrote:
> Use PACKAGECONFIG to offer some flexibility to the libmatchbox configuration,
> and remove two spurious build dependencies (expat and libstartup-notification).
[snip]
> -DEPENDS = "virtual/libx11 libxext expat libxft jpeg libpng zlib libxsettings-client startup-notification"
> +DEPENDS = "virtual/libx11 libxext"


  reply	other threads:[~2013-12-14 14:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-10 12:13 [PATCH 1/2] libmatchbox: fix libpng detection Ross Burton
2013-12-10 12:13 ` [PATCH 2/2] libmatchbox: use PACKAGECONFIG Ross Burton
2013-12-14 14:18   ` Trevor Woerner [this message]
2013-12-16 12:06     ` Burton, Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52AC68D0.1040208@linaro.org \
    --to=trevor.woerner@linaro.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox