From: ChenQi <Qi.Chen@windriver.com>
To: Saul Wold <sgw@linux.intel.com>,
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/2] busybox: enable SEAMLESS_XZ by default
Date: Tue, 24 Dec 2013 09:31:01 +0800 [thread overview]
Message-ID: <52B8E3D5.4000602@windriver.com> (raw)
In-Reply-To: <52B89023.80209@linux.intel.com>
On 12/24/2013 03:33 AM, Saul Wold wrote:
> On 12/23/2013 12:36 AM, Qi.Chen@windriver.com wrote:
>> From: Chen Qi <Qi.Chen@windriver.com>
>>
>> We have enabled SEAMLESS_GZ and SEAMLESS_BZ2 in defconfig, it's
>> reasonable for us to enable SEAMLESS_XZ as well. Otherwise, we
>> couldn't extract tar.xz file while we could extract tar.gz file.
>> Such situation would be somewhat confusing.
>>
> It's also important to note how much bigger the busybox image grows
> when adding a new config options, so what's the increase in # of bytes?
>
Hi Saul,
The total size increase is (511116 + 47184 - 499980 - 47184 = 11136) bytes.
Here's more data.
*) Before the change:
-rwxr-xr-x 2 chenqi chenqi 511116 Dec 23 02:44
tmp/work/i586-poky-linux/busybox/1.21.1-r0/packages-split/busybox/bin/busybox.nosuid
-rwsr-xr-x 2 chenqi chenqi 47184 Dec 23 02:44
tmp/work/i586-poky-linux/busybox/1.21.1-r0/packages-split/busybox/bin/busybox.suid
*) After the change:
-rwxr-xr-x 2 chenqi chenqi 499980 Dec 23 20:25
tmp/work/i586-poky-linux/busybox/1.21.1-r0/packages-split/busybox/bin/busybox.nosuid
-rwsr-xr-x 2 chenqi chenqi 47184 Dec 23 20:25
tmp/work/i586-poky-linux/busybox/1.21.1-r0/packages-split/busybox/bin/busybox.suid
Best Regards,
Chen Qi
> Thanks
> Sau!
>
>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>> ---
>> meta/recipes-core/busybox/busybox/defconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-core/busybox/busybox/defconfig
>> b/meta/recipes-core/busybox/busybox/defconfig
>> index f0e63c2..20cd147 100644
>> --- a/meta/recipes-core/busybox/busybox/defconfig
>> +++ b/meta/recipes-core/busybox/busybox/defconfig
>> @@ -125,7 +125,7 @@ CONFIG_FEATURE_HWIB=y
>> #
>> # Archival Utilities
>> #
>> -# CONFIG_FEATURE_SEAMLESS_XZ is not set
>> +CONFIG_FEATURE_SEAMLESS_XZ=y
>> CONFIG_FEATURE_SEAMLESS_LZMA=y
>> CONFIG_FEATURE_SEAMLESS_BZ2=y
>> CONFIG_FEATURE_SEAMLESS_GZ=y
>>
>
next prev parent reply other threads:[~2013-12-24 1:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 8:36 [PATCH 0/2] Fixes for systemd's ptest Qi.Chen
2013-12-23 8:36 ` [PATCH 1/2] busybox: enable SEAMLESS_XZ by default Qi.Chen
2013-12-23 19:33 ` Saul Wold
2013-12-24 1:31 ` ChenQi [this message]
2013-12-23 8:36 ` [PATCH 2/2] systemd: fix ptest to make it able to run on target Qi.Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B8E3D5.4000602@windriver.com \
--to=qi.chen@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=sgw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox